linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Jan Kara <jack@suse.cz>, "Theodore Y. Ts'o" <tytso@mit.edu>,
	Yong Sun <yosun@suse.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Cyril Hrubis <chrubis@suse.cz>
Subject: Re: "New" ext4 features tests in LTP
Date: Thu, 24 Oct 2019 10:37:15 +0200	[thread overview]
Message-ID: <20191024083713.GB13520@dell5510> (raw)
In-Reply-To: <20191024074619.GI31271@quack2.suse.cz>

Hi Ted, Jan,

> Yeah, I believe this may be useful to implement in fstests in some fs
> agnostic way.
Thank you both for reviewing LTP tests.

> > > ext4-nsec-timestamps [6]
> > > --------------------
> > > Directory containing the shell script which is used to test nanosec timestamps
> > > of ext4.

> > This basically tests that the file system supports nanosecond
> > timestamps, with a 0.3% false positive failure rate.   Again, why?

> > > ext4-subdir-limit [9]
> > > -----------------
> > > Directory containing the shell script which is used to test subdirectory limit
> > > of ext4. According to the kernel documentation, we create more than 32000
> > > subdirectorys on the ext4 filesystem.

> > This is a valid test, although it's not what I would call a "high
> > value" test.  (As in, it's testing maybe a total of four simple lines
> > of code that are highly unlikely to fail.)

> These two may be IMHO worth carrying over to fstests in some form. The other
> tests seem either already present in various fstests configs we run or
> pointless as Ted wrote.
As Sero already volunteered to contribute them to fstests (thanks Sero!),
I'll send a patch to delete them from LTP.

> 								Honza

Kind regards,
Petr

      reply	other threads:[~2019-10-24  8:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-23 15:58 "New" ext4 features tests in LTP Petr Vorel
2019-10-23 22:58 ` Theodore Y. Ts'o
2019-10-24  7:46   ` Jan Kara
2019-10-24  8:37     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024083713.GB13520@dell5510 \
    --to=pvorel@suse.cz \
    --cc=adilger.kernel@dilger.ca \
    --cc=chrubis@suse.cz \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yosun@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).