From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21ACBCA9EBC for ; Thu, 24 Oct 2019 13:23:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1E482084C for ; Thu, 24 Oct 2019 13:23:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="OQCC9fos" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2502526AbfJXNXP (ORCPT ); Thu, 24 Oct 2019 09:23:15 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:46586 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2502515AbfJXNXP (ORCPT ); Thu, 24 Oct 2019 09:23:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=gcU9exE6Bvro/lea/dgeXKEnFVXdIrFpf/E5Hgk7fI4=; b=OQCC9foswnxnaiFBJw3Vkn25h EYAPQY1qAspChDW7b9MiGr3xvZzEnkoJFlItmOqqQMuKR/ZYbKaWpl0U9RQ6lloZL7osMS1qn6Ow6 aWk1g63FvYQPN6aNWq8gvaLOVZyaCumFoludpul3tgKhob/nbDJjq4uR8cgUloPmSKzZOdRHtfHyc 1UEDbFuUYEkAqqinWPFaWz9z9C38x6reQS3b0Xysu8mwc3wpIZ2RSFOLNGZBxKZ2r2GPE5LpIDBIU vujiXu4n4Pz9PYh+gTk9i8t8xxMcbqb4UwrxGsXaSU391MPAxVU6XeAr3dY8/2Ul4JmJa15oFEhnX 0/GSrw+7Q==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNd58-0000Lv-KB; Thu, 24 Oct 2019 13:23:14 +0000 Date: Thu, 24 Oct 2019 06:23:14 -0700 From: Matthew Wilcox To: Christoph Hellwig Cc: Michal Suchanek , linux-scsi@vger.kernel.org, Jonathan Corbet , Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" , Alexander Viro , Mauro Carvalho Chehab , Eric Biggers , "J. Bruce Fields" , Benjamin Coddington , Hannes Reinecke , Omar Sandoval , Ming Lei , Damien Le Moal , Bart Van Assche , Tejun Heo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code Message-ID: <20191024132314.GG2963@bombadil.infradead.org> References: <20191024021958.GA11485@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024021958.GA11485@infradead.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Oct 23, 2019 at 07:19:58PM -0700, Christoph Hellwig wrote: > > static > > -int open_for_data(struct cdrom_device_info *cdi) > > +int open_for_common(struct cdrom_device_info *cdi, tracktype *tracks) > > Please fix the coding style. static never should be on a line of its > own.. It's OK to have the static on a line by itself; it's having 'static int' on a line by itself that Linus gets unhappy about because he can't use grep to see the return type. But there's no need for it to be on a line by itself here, it all fits fine in 80 columns.