From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Michal Suchanek <msuchanek@suse.de>,
linux-scsi@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Jens Axboe <axboe@kernel.dk>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Eric Biggers <ebiggers@google.com>,
"J. Bruce Fields" <bfields@redhat.com>,
Benjamin Coddington <bcodding@redhat.com>,
Hannes Reinecke <hare@suse.com>, Omar Sandoval <osandov@fb.com>,
Ming Lei <ming.lei@redhat.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Bart Van Assche <bvanassche@acm.org>, Tejun Heo <tj@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code
Date: Thu, 24 Oct 2019 19:38:30 -0700 [thread overview]
Message-ID: <20191025023830.GA14108@infradead.org> (raw)
In-Reply-To: <20191024132314.GG2963@bombadil.infradead.org>
On Thu, Oct 24, 2019 at 06:23:14AM -0700, Matthew Wilcox wrote:
> On Wed, Oct 23, 2019 at 07:19:58PM -0700, Christoph Hellwig wrote:
> > > static
> > > -int open_for_data(struct cdrom_device_info *cdi)
> > > +int open_for_common(struct cdrom_device_info *cdi, tracktype *tracks)
> >
> > Please fix the coding style. static never should be on a line of its
> > own..
>
> It's OK to have the static on a line by itself; it's having 'static int'
> on a line by itself that Linus gets unhappy about because he can't use
> grep to see the return type.
Sorry, but independent of any preference just looking at the codebases
proves you wrong. All on one line is the most common style, but not
by much, followed by static + type. Just static is just in a few crazy
next prev parent reply other threads:[~2019-10-25 2:38 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 12:52 [PATCH v2 0/8] Fix cdrom autoclose Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 1/8] cdrom: add poll_event_interruptible Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 2/8] cdrom: factor out common open_for_* code Michal Suchanek
2019-10-24 2:19 ` Christoph Hellwig
2019-10-24 8:50 ` Michal Suchánek
2019-10-25 2:39 ` Christoph Hellwig
2019-10-25 10:42 ` Michal Suchánek
2019-10-26 6:46 ` Finn Thain
2019-10-24 13:23 ` Matthew Wilcox
2019-10-25 2:38 ` Christoph Hellwig [this message]
2019-10-23 12:52 ` [PATCH v2 3/8] cdrom: wait for the tray to close Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 4/8] cdrom: separate autoclose into an IOCTL Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 5/8] docs: cdrom: Add autoclose IOCTL Michal Suchanek
2019-10-23 12:52 ` [PATCH v2 6/8] bdev: add open_finish Michal Suchanek
2019-10-24 2:22 ` Christoph Hellwig
2019-10-24 8:55 ` Michal Suchánek
2019-10-24 13:12 ` Matthew Wilcox
2019-10-24 13:19 ` Michal Suchánek
2019-11-21 10:15 ` Michal Suchánek
2019-10-23 12:52 ` [PATCH v2 7/8] scsi: sr: workaround VMware ESXi cdrom emulation bug Michal Suchanek
2019-10-23 14:13 ` Hannes Reinecke
2019-10-23 16:23 ` Michal Suchánek
2019-10-23 21:44 ` Ewan D. Milne
2019-10-24 5:46 ` Hannes Reinecke
2019-10-24 8:56 ` Michal Suchánek
2019-10-24 9:41 ` Hannes Reinecke
2019-10-24 10:11 ` Michal Suchánek
2019-10-24 2:23 ` Christoph Hellwig
2019-10-24 8:53 ` Michal Suchánek
2019-11-21 15:21 ` Michal Suchánek
2019-10-23 12:52 ` [PATCH v2 8/8] scsi: sr: wait for the medium to become ready Michal Suchanek
2019-10-24 2:24 ` Christoph Hellwig
2019-10-24 8:51 ` Michal Suchánek
2019-10-24 13:14 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025023830.GA14108@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bcodding@redhat.com \
--cc=bfields@redhat.com \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=damien.lemoal@wdc.com \
--cc=ebiggers@google.com \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab+samsung@kernel.org \
--cc=ming.lei@redhat.com \
--cc=msuchanek@suse.de \
--cc=osandov@fb.com \
--cc=tj@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).