From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BB3DCA9EBC for ; Fri, 25 Oct 2019 02:39:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DEB3621D81 for ; Fri, 25 Oct 2019 02:39:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dL3ngCsL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390362AbfJYCjJ (ORCPT ); Thu, 24 Oct 2019 22:39:09 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:41440 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728416AbfJYCjJ (ORCPT ); Thu, 24 Oct 2019 22:39:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sVL72IEnASGUFIun+CE72v94BxJjKdJ1NDcm7LwViSw=; b=dL3ngCsLRac53SA2YNqk+ZHSH5 /c+2xQjru/wv3o1K9PFWtdRc+BJWDT9L7Fm9GRiDQAvV8vRB45MnBE750UHjij1PwEf5tBSG6e2l6 /Tg+3oFNXeFsCALow9InwXg4UdprbSzoxL9wjNSbCrnjbAmFmgmARliJ5PP9Jt0n/5Lce4uHz3Jyw CiSgP7n/s3xVb/xPTWpl4uXywI0WOyvsRKTMCzYi1sYssZ9fSAOxRKrbVtReTgSMO3XPm5SSlBtRO lMWsTttycMSw5WoLF9mldBrdK2PQgzz2zsjxcXDnBh3fA7M1eejwnHXPwp/77YQh95XZdnWeMrKi/ ZuW4lIFA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNpVM-0003py-Ui; Fri, 25 Oct 2019 02:39:08 +0000 Date: Thu, 24 Oct 2019 19:39:08 -0700 From: Christoph Hellwig To: Michal =?iso-8859-1?Q?Such=E1nek?= Cc: Christoph Hellwig , linux-scsi@vger.kernel.org, Jonathan Corbet , Jens Axboe , "James E.J. Bottomley" , "Martin K. Petersen" , Alexander Viro , Mauro Carvalho Chehab , Eric Biggers , "J. Bruce Fields" , Benjamin Coddington , Hannes Reinecke , Omar Sandoval , Ming Lei , Damien Le Moal , Bart Van Assche , Tejun Heo , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code Message-ID: <20191025023908.GB14108@infradead.org> References: <20191024021958.GA11485@infradead.org> <20191024085014.GF938@kitsune.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191024085014.GF938@kitsune.suse.cz> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Thu, Oct 24, 2019 at 10:50:14AM +0200, Michal Suchánek wrote: > Then I will get complaints I do unrelated changes and it's hard to > review. The code gets removed later anyway. If you refactor you you pretty much have a card blanche for the refactored code and the direct surroundings.