From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs: don't implement XFS_IOC_RESVSP / XFS_IOC_RESVSP64 directly
Date: Thu, 24 Oct 2019 22:32:42 -0700 [thread overview]
Message-ID: <20191025053242.GE913374@magnolia> (raw)
In-Reply-To: <20191025023609.22295-2-hch@lst.de>
On Fri, Oct 25, 2019 at 11:36:06AM +0900, Christoph Hellwig wrote:
> These ioctls are implemented by the VFS and mapped to ->fallocate now,
> so this code won't ever be reached.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/xfs_ioctl.c | 10 ----------
> fs/xfs/xfs_ioctl32.c | 2 --
> 2 files changed, 12 deletions(-)
>
> diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c
> index 0fed56d3175c..da4aaa75cfd3 100644
> --- a/fs/xfs/xfs_ioctl.c
> +++ b/fs/xfs/xfs_ioctl.c
> @@ -643,8 +643,6 @@ xfs_ioc_space(
> */
> switch (cmd) {
> case XFS_IOC_ZERO_RANGE:
> - case XFS_IOC_RESVSP:
> - case XFS_IOC_RESVSP64:
> case XFS_IOC_UNRESVSP:
> case XFS_IOC_UNRESVSP64:
> if (bf->l_len <= 0) {
> @@ -670,12 +668,6 @@ xfs_ioc_space(
> flags |= XFS_PREALLOC_SET;
> error = xfs_zero_file_space(ip, bf->l_start, bf->l_len);
> break;
> - case XFS_IOC_RESVSP:
> - case XFS_IOC_RESVSP64:
> - flags |= XFS_PREALLOC_SET;
> - error = xfs_alloc_file_space(ip, bf->l_start, bf->l_len,
> - XFS_BMAPI_PREALLOC);
> - break;
> case XFS_IOC_UNRESVSP:
> case XFS_IOC_UNRESVSP64:
> error = xfs_free_file_space(ip, bf->l_start, bf->l_len);
> @@ -2121,11 +2113,9 @@ xfs_file_ioctl(
> return xfs_ioc_setlabel(filp, mp, arg);
> case XFS_IOC_ALLOCSP:
> case XFS_IOC_FREESP:
> - case XFS_IOC_RESVSP:
> case XFS_IOC_UNRESVSP:
> case XFS_IOC_ALLOCSP64:
> case XFS_IOC_FREESP64:
> - case XFS_IOC_RESVSP64:
> case XFS_IOC_UNRESVSP64:
> case XFS_IOC_ZERO_RANGE: {
> xfs_flock64_t bf;
> diff --git a/fs/xfs/xfs_ioctl32.c b/fs/xfs/xfs_ioctl32.c
> index 1e08bf79b478..257b7caf7fed 100644
> --- a/fs/xfs/xfs_ioctl32.c
> +++ b/fs/xfs/xfs_ioctl32.c
> @@ -558,8 +558,6 @@ xfs_file_compat_ioctl(
> case XFS_IOC_FREESP_32:
> case XFS_IOC_ALLOCSP64_32:
> case XFS_IOC_FREESP64_32:
> - case XFS_IOC_RESVSP_32:
> - case XFS_IOC_UNRESVSP_32:
> case XFS_IOC_RESVSP64_32:
> case XFS_IOC_UNRESVSP64_32:
> case XFS_IOC_ZERO_RANGE_32: {
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-10-25 5:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 2:36 clean up xfs space management interfaces Christoph Hellwig
2019-10-25 2:36 ` [PATCH 1/4] xfs: don't implement XFS_IOC_RESVSP / XFS_IOC_RESVSP64 directly Christoph Hellwig
2019-10-25 5:32 ` Darrick J. Wong [this message]
2019-10-25 2:36 ` [PATCH 2/4] fs: add generic UNRESVSP and ZERO_RANGE ioctl handlers Christoph Hellwig
2019-10-25 5:44 ` Darrick J. Wong
2019-10-25 9:50 ` Christoph Hellwig
2019-10-26 20:56 ` Dave Chinner
2019-10-27 15:19 ` Christoph Hellwig
2019-10-25 2:36 ` [PATCH 3/4] xfs: disable xfs_ioc_space for always COW inodes Christoph Hellwig
2019-10-25 5:45 ` Darrick J. Wong
2019-10-25 2:36 ` [PATCH 4/4] xfs: consolidate preallocation in xfs_file_fallocate Christoph Hellwig
2019-10-25 5:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025053242.GE913374@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).