From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81A88C43331 for ; Mon, 11 Nov 2019 09:16:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 60C8220656 for ; Mon, 11 Nov 2019 09:16:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726951AbfKKJQs (ORCPT ); Mon, 11 Nov 2019 04:16:48 -0500 Received: from verein.lst.de ([213.95.11.211]:48230 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726768AbfKKJQs (ORCPT ); Mon, 11 Nov 2019 04:16:48 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 061B968BE1; Mon, 11 Nov 2019 10:16:45 +0100 (CET) Date: Mon, 11 Nov 2019 10:16:44 +0100 From: Christoph Hellwig To: Al Viro Cc: "J. Bruce Fields" , Ritesh Harjani , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, wugyuan@cn.ibm.com, jlayton@kernel.org, hsiangkao@aol.com, Jan Kara , Linus Torvalds , Christoph Hellwig Subject: Re: [PATCH][RFC] race in exportfs_decode_fh() Message-ID: <20191111091644.GA11108@lst.de> References: <20190927044243.18856-1-riteshh@linux.ibm.com> <20191015040730.6A84742047@d06av24.portsmouth.uk.ibm.com> <20191022133855.B1B4752050@d06av21.portsmouth.uk.ibm.com> <20191022143736.GX26530@ZenIV.linux.org.uk> <20191022201131.GZ26530@ZenIV.linux.org.uk> <20191023110551.D04AE4C044@d06av22.portsmouth.uk.ibm.com> <20191101234622.GM26530@ZenIV.linux.org.uk> <20191102172229.GT20975@paulmck-ThinkPad-P72> <20191102180842.GN26530@ZenIV.linux.org.uk> <20191109031333.GA8566@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191109031333.GA8566@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Sat, Nov 09, 2019 at 03:13:33AM +0000, Al Viro wrote: > Does anyone see objections to the following patch? Christoph, that seems to > be your code; am I missing something subtle here? AFAICS, that goes back to > 2007 or so... This goes back to way before that, that series jut factored out proper export operations from the two inode or superblock methods we had before with the rest handled in core code somewhere that made a complete mess of file systems with 64-bit inode numbers. Otherwise this looks fine, although splitting the refactoring from the actual change would make for a much more readable series.