From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E3B8C43215 for ; Fri, 22 Nov 2019 05:53:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2319920672 for ; Fri, 22 Nov 2019 05:53:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="RA8eqBfd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728896AbfKVFxq (ORCPT ); Fri, 22 Nov 2019 00:53:46 -0500 Received: from mail-pl1-f194.google.com ([209.85.214.194]:45902 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728847AbfKVFxo (ORCPT ); Fri, 22 Nov 2019 00:53:44 -0500 Received: by mail-pl1-f194.google.com with SMTP id w7so2633323plz.12 for ; Thu, 21 Nov 2019 21:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xL8yI/1Gr9pFEvF3XN2/mbVw7cvtJ5vGivyK7ET8Uns=; b=RA8eqBfd/fPZmuHXu2jsDZqldtL8MY9mZEvq1vN6w2YCCHaUMGPmAuZh2t5joccdkw 3Kc2fOP7q+HZkwtQS4ZpJiiVVfOK2uqROQkfMyie0083xn9LRG14AjPx1pQ1n8sTylh5 RSy66JFiyFHGAkYh0rAA8jm9nE2zzTZYDW+jUS8NHt+QNt3mgkteDq44j+Rnq7L6aIzU UtkqNbl35UM0vtmiEjKsI8Cyd7o+GdDEI5HLOPWfKYUuzVDDN0ulPYIA+zjGM9UAoAiW RMFnYGizpH+DTBHv6bFxcGxreBE27LbbC8xafOjS1moGHJa9xC/oBzaV9P6Aw4qt3HWt aDdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xL8yI/1Gr9pFEvF3XN2/mbVw7cvtJ5vGivyK7ET8Uns=; b=sx3YdY1U6IqteUkZz2AxJwiGwvQmJ1bhWkKTqk09UoxZOICx/QLJidsfk9zSC4eEIk 2ReDWg572Ud1zzxynPlo1IQs7MnRhdRJZtqFVcGuKv3IVynXw/bQ01NWAXtPe0oQ2Yr1 NE4OV1gERaHVHA5LzFLYzOHuTNvfEQ8uG8419alfOEMYsIuqtFCbiy/R30+XhgGkyEeq CHpqSDwNI7RUcYLIQmQ6mLsfdOjrn1ZBhW2+8CLfyFsvK0OkUK1Y6lMmvFvhjrO6qUDJ Gn6q3Ypqbi96vdWwCXt35cpKfFKqT6qkePj8pLJ6ap1NC+tY8C+08AGuPUk3mSTsL40v up+Q== X-Gm-Message-State: APjAAAUh8qjIuXnEmT/QR75BG/Vwm+DW6XU42MmepQT2rXo5we+rTeq2 fnhfZNVV37RNKB9n9fXSsYYFGzsx9g== X-Google-Smtp-Source: APXvYqwZbS5abHHMUAqp7WPVGUN/CVcIKOOtjnPq0Lyo+S/rC4DvPWY6IWUiB4cYHw+4SBGg2/FO3g== X-Received: by 2002:a17:902:8d98:: with SMTP id v24mr11879747plo.159.1574402018641; Thu, 21 Nov 2019 21:53:38 -0800 (PST) Received: from bobrowski ([110.232.114.101]) by smtp.gmail.com with ESMTPSA id 13sm5290446pgq.72.2019.11.21.21.53.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2019 21:53:38 -0800 (PST) Date: Fri, 22 Nov 2019 16:53:32 +1100 From: Matthew Bobrowski To: Ritesh Harjani Cc: jack@suse.cz, tytso@mit.edu, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFCv3 1/4] ext4: fix ext4_dax_read/write inode locking sequence for IOCB_NOWAIT Message-ID: <20191122055330.GA13688@bobrowski> References: <20191120050024.11161-1-riteshh@linux.ibm.com> <20191120050024.11161-2-riteshh@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191120050024.11161-2-riteshh@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Nov 20, 2019 at 10:30:21AM +0530, Ritesh Harjani wrote: > Apparently our current rwsem code doesn't like doing the trylock, then > lock for real scheme. So change our dax read/write methods to just do the > trylock for the RWF_NOWAIT case. > This seems to fix AIM7 regression in some scalable filesystems upto ~25% > in some cases. Claimed in commit 942491c9e6d6 ("xfs: fix AIM7 regression") > > Signed-off-by: Ritesh Harjani This looks OK to me. Feel free to add: Reviewed-by: Matthew Bobrowski /M