From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Eric Biggers <ebiggers@kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] iomap: Fix pipe page leakage during splicing
Date: Fri, 22 Nov 2019 17:04:17 +1100 [thread overview]
Message-ID: <20191122060415.GA13786@bobrowski> (raw)
In-Reply-To: <20191121235528.GO6211@magnolia>
On Thu, Nov 21, 2019 at 03:55:28PM -0800, Darrick J. Wong wrote:
> On Thu, Nov 21, 2019 at 05:15:34PM +0100, Jan Kara wrote:
> > @@ -497,8 +497,15 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
> > }
> > pos += ret;
> >
> > - if (iov_iter_rw(iter) == READ && pos >= dio->i_size)
> > + if (iov_iter_rw(iter) == READ && pos >= dio->i_size) {
> > + /*
> > + * We will report we've read data only upto i_size.
>
> Nit: "up to"; will fix that on the way in.
A nit of a nit: "We will report that we've read..."; I think it reads
better, so might as well update it if you're already fixing the other
nit up as you're pulling this in. :P
/M
next prev parent reply other threads:[~2019-11-22 6:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 16:15 [PATCH 0/2] iomap: Fix leakage of pipe pages while splicing Jan Kara
2019-11-21 16:15 ` [PATCH 1/2] iomap: Fix pipe page leakage during splicing Jan Kara
2019-11-21 23:55 ` Darrick J. Wong
2019-11-22 6:04 ` Matthew Bobrowski [this message]
2019-11-22 10:47 ` Jan Kara
2019-11-22 13:17 ` Christoph Hellwig
2019-11-21 16:15 ` [PATCH 2/2] iomap: Do not create fake iter in iomap_dio_bio_actor() Jan Kara
2019-11-22 0:02 ` Darrick J. Wong
2019-11-22 12:11 ` Jan Kara
2019-11-22 13:26 ` Christoph Hellwig
2019-11-25 8:18 ` Jan Kara
2019-11-21 16:58 ` [PATCH 0/2] iomap: Fix leakage of pipe pages while splicing Darrick J. Wong
2019-11-21 17:15 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122060415.GA13786@bobrowski \
--to=mbobrowski@mbobrowski.org \
--cc=darrick.wong@oracle.com \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox