From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UPPERCASE_50_75,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F28C432C3 for ; Tue, 26 Nov 2019 17:36:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7C572071E for ; Tue, 26 Nov 2019 17:36:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="rGNbv7Q/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728168AbfKZRgO (ORCPT ); Tue, 26 Nov 2019 12:36:14 -0500 Received: from mail-pl1-f196.google.com ([209.85.214.196]:33968 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728028AbfKZRgO (ORCPT ); Tue, 26 Nov 2019 12:36:14 -0500 Received: by mail-pl1-f196.google.com with SMTP id h13so8468017plr.1 for ; Tue, 26 Nov 2019 09:36:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=NtvB90Am5ZTLYm+Aanm0y4QmpQ4zRvwI0Pg1w2+PDpk=; b=rGNbv7Q/X/5vfOv3mEOUHT0ifP2BNEzSFwVUFi60A3yjv16WqHdBPaULOwt59Zn5jT gRvE//8RWtJpaj/TRQfMmRf6SBpTz2Y54xeympjIDF/o3ZrhXFas7GBOqXuO4RYEQokq DeGwcPrVZvj6zd6bHf5EGPJOWL4UEEQX7sImp33qn01RPtL3vw9ts8Lg9n4GyoDbCFD9 UM3t9zmxGiVNPZatYm0w8uT0PYKSAv1YccttU0918i+7vjV/dtx5Fw2UcVFnXXV8IcOL LJ8UlYU64ghrRk56ahQOTQOWpwcXe1Ss0w/j2aWx47gGCqN2Xnt05Kw4FiDRlZv4LqvY Lj6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=NtvB90Am5ZTLYm+Aanm0y4QmpQ4zRvwI0Pg1w2+PDpk=; b=GNXL22+9yWZqVv11iojOWYA5MS+opy6o3DICx7TrGhZH1RDULIh3u4MmdLssV1b8kI +/QnsoTxuyO3sNaPP+G4MTLerNDhlO1x7yCHoQHRwS3SrHJJ6+PbtDAq3vfw519QZF/d J/5EONJC3OP9X8wydx6MIZHm+5LB9iK6bZkbNbzyb0riduX17qX4I17A3PUQ2txM1NVu uhXIKO3blEE7fDQCTKbS29L1UjgL0NuLo/aAePZEZnG8Y6XcXvpuwyKoMxbz4J8APu5y 0jQu9GxK40gXQlbeTBt2SNH4yPZ+QadQniUhik3DMOSp05HuIhQ5piR0m7oGIk7ba80c MdVA== X-Gm-Message-State: APjAAAWuBCNPr8blZPNA6cMTo+WDlh3JfhVZAwzCqnpUfQUq+9Ys/tuu WJ9VMRzpwjmN0GqOUY6GnqqutA== X-Google-Smtp-Source: APXvYqxQGleSEyUIqfvJa8/NiJsP5dYY2++4KZCeuP6V5fzHKL8ASxLjBD4+U8MsBGYZ6bwvbS0HNA== X-Received: by 2002:a17:902:d881:: with SMTP id b1mr35712590plz.170.1574789771532; Tue, 26 Nov 2019 09:36:11 -0800 (PST) Received: from vader ([2620:10d:c090:180::92f5]) by smtp.gmail.com with ESMTPSA id c28sm13143566pgc.65.2019.11.26.09.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 09:36:10 -0800 (PST) Date: Tue, 26 Nov 2019 09:36:07 -0800 From: Omar Sandoval To: Nikolay Borisov Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH v3 03/12] fs: add RWF_ENCODED for reading/writing compressed data Message-ID: <20191126173607.GA657777@vader> References: <07f9cc1969052e94818fa50019e7589d206d1d18.1574273658.git.osandov@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Nov 26, 2019 at 03:53:02PM +0200, Nikolay Borisov wrote: > > > On 20.11.19 г. 20:24 ч., Omar Sandoval wrote: > > From: Omar Sandoval > > > > > > > +enum { > > + ENCODED_IOV_COMPRESSION_NONE, > > +#define ENCODED_IOV_COMPRESSION_NONE ENCODED_IOV_COMPRESSION_NONE > > + ENCODED_IOV_COMPRESSION_ZLIB, > > +#define ENCODED_IOV_COMPRESSION_ZLIB ENCODED_IOV_COMPRESSION_ZLIB > > + ENCODED_IOV_COMPRESSION_LZO, > > +#define ENCODED_IOV_COMPRESSION_LZO ENCODED_IOV_COMPRESSION_LZO > > + ENCODED_IOV_COMPRESSION_ZSTD, > > +#define ENCODED_IOV_COMPRESSION_ZSTD ENCODED_IOV_COMPRESSION_ZSTD > > + ENCODED_IOV_COMPRESSION_TYPES = ENCODED_IOV_COMPRESSION_ZSTD, > > This looks very dodgy, what am I missing? This is a somewhat common trick so that enum values can be checked for with ifdef/ifndef. See include/uapi/linux.in.h, for example.