From: Matthew Bobrowski <mbobrowski@mbobrowski.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Jan Kara <jack@suse.cz>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, Eric Biggers <ebiggers@kernel.org>
Subject: Re: [PATCH] iomap: Do not create fake iter in iomap_dio_bio_actor()
Date: Wed, 27 Nov 2019 08:47:11 +1100 [thread overview]
Message-ID: <20191126214707.GB23868@bobrowski> (raw)
In-Reply-To: <20191126151216.GD20752@bombadil.infradead.org>
On Tue, Nov 26, 2019 at 07:12:16AM -0800, Matthew Wilcox wrote:
> On Tue, Nov 26, 2019 at 08:11:50AM +1100, Matthew Bobrowski wrote:
> > > + * are operating on right now. The iter will be re-expanded once
> > ^^
> > Extra whitespace here.
>
> That's controversial, not wrong. We don't normally enforce a style there.
> https://www.theatlantic.com/science/archive/2018/05/two-spaces-after-a-period/559304/
> (for example. you can find many many many pieces extolling one or
> two spaces).
Indeed controversial, a good read, and thank you for sharing. I guess
that I haven't been brought up with two spaces after a period being a
"thing", so it makes my wires trip when glancing over a snippet of
text.
At least I'll know this for next time. :)
/M
next prev parent reply other threads:[~2019-11-26 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 11:18 [PATCH 0/2 v2] iomap: Cleanup of iomap_dio_rw() Jan Kara
2019-11-25 11:18 ` [PATCH] iomap: Do not create fake iter in iomap_dio_bio_actor() Jan Kara
2019-11-25 17:53 ` Christoph Hellwig
2019-11-25 21:11 ` Matthew Bobrowski
2019-11-26 15:12 ` Matthew Wilcox
2019-11-26 21:47 ` Matthew Bobrowski [this message]
2019-11-26 16:31 ` Christoph Hellwig
2019-11-26 17:47 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126214707.GB23868@bobrowski \
--to=mbobrowski@mbobrowski.org \
--cc=darrick.wong@oracle.com \
--cc=ebiggers@kernel.org \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).