From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C763DC432C0 for ; Tue, 26 Nov 2019 21:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 957B720678 for ; Tue, 26 Nov 2019 21:47:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mbobrowski-org.20150623.gappssmtp.com header.i=@mbobrowski-org.20150623.gappssmtp.com header.b="IfCawLHb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbfKZVrU (ORCPT ); Tue, 26 Nov 2019 16:47:20 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:39735 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726118AbfKZVrT (ORCPT ); Tue, 26 Nov 2019 16:47:19 -0500 Received: by mail-pj1-f66.google.com with SMTP id v93so5644715pjb.6 for ; Tue, 26 Nov 2019 13:47:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mbobrowski-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KFhdOn90Fti7JE5QyN26X7BwGNx6h4gloValNPbrSLg=; b=IfCawLHbaEt8FD7nRs/gvbRk47OJhOhEHuv0lWdW3MuIJK8M414nyXPgo47mJIFeN7 PaBMCVfl1x0wwVWip+WmSBigPOHJJiuZ0B+TXeZ9RBNdvd5OpFgGDj2I/pMuuRNvlsno stVl4+y5iGv1PMWKQJxgrUFe2r9kDtKxtRFufA0wt8dd78h7dn56xwa9R4MTPEGhXwd0 GS/ubITYNkLp5iBjzjJ+Gggjyfypkx+sZsjIB5UxweZzLOWZVIB9CVWzS8n9fEUHItDi 4hUgNm/87MQDcsfWVnWVtuiqEPBdErYSij7cdo7G+r9pVbB3g0Kbdnp/hnb5UrE6Ji3V 4JWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KFhdOn90Fti7JE5QyN26X7BwGNx6h4gloValNPbrSLg=; b=qaqDhMv3IfOCJCzNMeUudbYtHAcDgvvaVpWIQqd6WClr79i7rHPeK1cLxtx2klzxoq hxZ62k/ulCwNCh+eTjVY1vK4PiLbbs7I/o6l5fy1jZ2ziuto0gosS0OwFoLJg1OVFvGv wIjFtiK2k3qttiiXcruWDQhxeXixqXm8k5pH68+1nhuo+G1EMnkVC/gbsoDmrdyVFGjZ 5M0eYjtHnB/o+bcmkmt3k6LRzKZtJU4ZBpawKSFQzRQllc7vgN6b+3ZHFbCKBGs1YeSb sY2k0xdO6POR716GRbZ3DqRTNHUdYI+NAxnvIGQgEvT/BpMBXFTpHGMEahbIP8+xGwE5 TpJg== X-Gm-Message-State: APjAAAWHyt0ztVo8rLxuw9CENvDuEuCkF2YFE6NoQig+3wcLmZ1Tl2b6 a0XuJJwiELlhEFqPoYhgKDUp X-Google-Smtp-Source: APXvYqyIY6rc51MCcvspRmZcVyOW9dwwtHhFMhC7SrUpiiXWoM1Cn/6GCIJVGKi2KqAoGfANcVftJA== X-Received: by 2002:a17:90a:1424:: with SMTP id j33mr1733161pja.2.1574804838387; Tue, 26 Nov 2019 13:47:18 -0800 (PST) Received: from bobrowski (bobrowski.net. [110.232.114.101]) by smtp.gmail.com with ESMTPSA id o124sm13924729pfb.56.2019.11.26.13.47.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 13:47:17 -0800 (PST) Date: Wed, 27 Nov 2019 08:47:11 +1100 From: Matthew Bobrowski To: Matthew Wilcox Cc: Jan Kara , "Darrick J. Wong" , Christoph Hellwig , linux-fsdevel@vger.kernel.org, Eric Biggers Subject: Re: [PATCH] iomap: Do not create fake iter in iomap_dio_bio_actor() Message-ID: <20191126214707.GB23868@bobrowski> References: <20191125083930.11854-1-jack@suse.cz> <20191125111901.11910-1-jack@suse.cz> <20191125211149.GC3748@bobrowski> <20191126151216.GD20752@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191126151216.GD20752@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Nov 26, 2019 at 07:12:16AM -0800, Matthew Wilcox wrote: > On Tue, Nov 26, 2019 at 08:11:50AM +1100, Matthew Bobrowski wrote: > > > + * are operating on right now. The iter will be re-expanded once > > ^^ > > Extra whitespace here. > > That's controversial, not wrong. We don't normally enforce a style there. > https://www.theatlantic.com/science/archive/2018/05/two-spaces-after-a-period/559304/ > (for example. you can find many many many pieces extolling one or > two spaces). Indeed controversial, a good read, and thank you for sharing. I guess that I haven't been brought up with two spaces after a period being a "thing", so it makes my wires trip when glancing over a snippet of text. At least I'll know this for next time. :) /M