From: Matthew Wilcox <willy@infradead.org>
To: Eric Snowberg <eric.snowberg@oracle.com>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
dhowells@redhat.com, matthewgarrett@google.com,
jmorris@namei.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] debugfs: Return -EPERM when locked down
Date: Fri, 6 Dec 2019 15:43:18 -0800 [thread overview]
Message-ID: <20191206234318.GA16467@bombadil.infradead.org> (raw)
In-Reply-To: <20191206225909.46721-1-eric.snowberg@oracle.com>
On Fri, Dec 06, 2019 at 05:59:09PM -0500, Eric Snowberg wrote:
> -static bool debugfs_is_locked_down(struct inode *inode,
> +static int debugfs_is_locked_down(struct inode *inode,
I might rename this function to debugfs_locked_down() to make it sound
less like it returns a boolean.
Other than that,
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
next prev parent reply other threads:[~2019-12-06 23:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 22:59 [PATCH] debugfs: Return -EPERM when locked down Eric Snowberg
2019-12-06 23:43 ` Matthew Wilcox [this message]
2019-12-07 8:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206234318.GA16467@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).