From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19274C43603 for ; Mon, 9 Dec 2019 05:50:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E243120721 for ; Mon, 9 Dec 2019 05:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575870622; bh=R0dRoRAY4AWuXuEgdxQagG5YTnurfWd7YsIc+RAjjm4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=Yz5NXrd9ptwE3LsASYp2LqHjZ/lKUaKKepoxYOeKeApj7b63WPeUamnqRmNxS6Rbn ZkswPxFbrync4Tg+R7uBxHkaQ6oCu50AGANjCt6OzreG9W2gMAPL+Ntw92gpTIELKW JdId89EYf2Oo9pfP3S2h/7mzF9z4ATJsvEmNd3kw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbfLIFuS (ORCPT ); Mon, 9 Dec 2019 00:50:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:49418 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726132AbfLIFuR (ORCPT ); Mon, 9 Dec 2019 00:50:17 -0500 Received: from devnote2 (unknown [180.22.253.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 900B7206D3; Mon, 9 Dec 2019 05:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575870616; bh=R0dRoRAY4AWuXuEgdxQagG5YTnurfWd7YsIc+RAjjm4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hJ2OFgv607/k4OkLsAE8Hq05LS5VDWUVqa5DhA5j1JUbAu4R7M0wYkGxUdcH/YpiU LCH2U9ImHSBbq93kGzXoDymA4vyJZ8wtlj7t5EH4d9UjyVNtgrMt7hSxcL980liOrn V0ltYqG+b31v/MYVS8YCkKqFr7yVOwKCwhwDHtuo= Date: Mon, 9 Dec 2019 14:50:09 +0900 From: Masami Hiramatsu To: Randy Dunlap Cc: Steven Rostedt , Frank Rowand , Ingo Molnar , Namhyung Kim , Tim Bird , Jiri Olsa , Arnaldo Carvalho de Melo , Tom Zanussi , Rob Herring , Andrew Morton , Thomas Gleixner , Greg Kroah-Hartman , Alexey Dobriyan , Jonathan Corbet , Linus Torvalds , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v4 01/22] bootconfig: Add Extra Boot Config support Message-Id: <20191209145009.502ece2e58ffab5e31430a0e@kernel.org> In-Reply-To: <02b132dd-6f50-cf1d-6cc1-ff6bbbcf79cd@infradead.org> References: <157528159833.22451.14878731055438721716.stgit@devnote2> <157528160980.22451.2034344493364709160.stgit@devnote2> <02b132dd-6f50-cf1d-6cc1-ff6bbbcf79cd@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hi Randy, Thank you for your review! On Sun, 8 Dec 2019 11:34:32 -0800 Randy Dunlap wrote: > Hi, > > On 12/2/19 2:13 AM, Masami Hiramatsu wrote: > > diff --git a/init/Kconfig b/init/Kconfig > > index 67a602ee17f1..13bb3eac804c 100644 > > --- a/init/Kconfig > > +++ b/init/Kconfig > > @@ -1235,6 +1235,17 @@ source "usr/Kconfig" > > > > endif > > > > +config BOOT_CONFIG > > + bool "Boot config support" > > + select LIBXBC > > + default y > > questionable "default y". > That needs lots of justification. OK, I can make it 'n' by default. I thought that was OK because most of the memories for the bootconfig support were released after initialization. If user doesn't pass the bootconfig, only the code for /proc/bootconfig remains on runtime memory. > > + help > > + Extra boot config allows system admin to pass a config file as > > + complemental extension of kernel cmdline when boot. > > when booting. OK. > > > + The boot config file is usually attached at the end of initramfs. > > The 3 help text lines above should be indented with one tab + 2 spaces, > like the "If" line below. Ah, thanks for pointing it out! I'll fix that. Thank you, > > > + > > + If unsure, say Y. > > + > > choice > > prompt "Compiler optimization level" > > default CC_OPTIMIZE_FOR_PERFORMANCE > > > -- > ~Randy > -- Masami Hiramatsu