From: Matthew Wilcox <willy@infradead.org>
To: Gao Xiang <gaoxiang25@huawei.com>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
Al Viro <viro@zeniv.linux.org.uk>,
Eric Biggers <ebiggers@kernel.org>,
"Theodore Y. Ts'o" <tytso@mit.edu>,
Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
Tyler Hicks <tyhicks@canonical.com>,
linux-fsdevel@vger.kernel.org, ecryptfs@vger.kernel.org,
linux-fscrypt@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH v5] fs: introduce is_dot_or_dotdot helper for cleanup
Date: Wed, 11 Dec 2019 05:40:14 -0800 [thread overview]
Message-ID: <20191211134014.GM32169@bombadil.infradead.org> (raw)
In-Reply-To: <20191211071711.GA231266@architecture4>
On Wed, Dec 11, 2019 at 03:17:11PM +0800, Gao Xiang wrote:
> > static inline bool is_dot_or_dotdot(const unsigned char *name, size_t len)
> > {
> > if (len >= 1 && unlikely(name[0] == '.')) {
>
>
> And I suggest drop "unlikely" here since files start with prefix
> '.' (plus specical ".", "..") are not as uncommon as you expected...
They absolutely are uncommon. Even if you just consider
/home/willy/kernel/linux/.git/config, only one of those six path elements
starts with a '.'.
next prev parent reply other threads:[~2019-12-11 13:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 2:20 [PATCH v5] fs: introduce is_dot_or_dotdot helper for cleanup Tiezhu Yang
2019-12-11 2:48 ` Eric Biggers
2019-12-11 3:59 ` Tiezhu Yang
2019-12-11 4:47 ` Al Viro
2019-12-11 6:38 ` Tiezhu Yang
2019-12-11 7:17 ` Gao Xiang
2019-12-11 13:40 ` Matthew Wilcox [this message]
2019-12-11 14:41 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211134014.GM32169@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=ebiggers@kernel.org \
--cc=ecryptfs@vger.kernel.org \
--cc=gaoxiang25@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tyhicks@canonical.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yangtiezhu@loongson.cn \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).