From: Christoph Hellwig <hch@infradead.org>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
hch@infradead.org, darrick.wong@oracle.com, fdmanana@kernel.org,
dsterba@suse.cz, jthumshirn@suse.de, nborisov@suse.com,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 4/8] iomap: Move lockdep_assert_held() to iomap_dio_rw() calls
Date: Thu, 12 Dec 2019 01:50:44 -0800 [thread overview]
Message-ID: <20191212095044.GD15977@infradead.org> (raw)
In-Reply-To: <20191212003043.31093-5-rgoldwyn@suse.de>
On Wed, Dec 11, 2019 at 06:30:39PM -0600, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> Filesystems such as btrfs can perform direct I/O without holding the
> inode->i_rwsem in some of the cases like writing within i_size.
How is that safe?
> + lockdep_assert_held(&file_inode(file)->i_rwsem);
Having the asserts in the callers is pointless. The assert is inside
the iomap helper to ensure the expected calling conventions, as the
code is written under the assumption that we have i_rwsem.
next prev parent reply other threads:[~2019-12-12 9:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 0:30 [PATCH 0/8 v5] btrfs direct-io using iomap Goldwyn Rodrigues
2019-12-12 0:30 ` [PATCH 1/8] fs: Export generic_file_buffered_read() Goldwyn Rodrigues
2019-12-12 9:46 ` Christoph Hellwig
2019-12-12 0:30 ` [PATCH 2/8] iomap: add a filesystem hook for direct I/O bio submission Goldwyn Rodrigues
2019-12-12 9:47 ` Christoph Hellwig
2019-12-12 0:30 ` [PATCH 3/8] btrfs: Switch to iomap_dio_rw() for dio Goldwyn Rodrigues
2019-12-12 9:49 ` Christoph Hellwig
2019-12-12 9:56 ` Johannes Thumshirn
2019-12-12 9:57 ` Christoph Hellwig
2019-12-12 10:38 ` Johannes Thumshirn
2019-12-12 19:42 ` Goldwyn Rodrigues
2019-12-12 0:30 ` [PATCH 4/8] iomap: Move lockdep_assert_held() to iomap_dio_rw() calls Goldwyn Rodrigues
2019-12-12 9:50 ` Christoph Hellwig [this message]
2019-12-12 22:24 ` Goldwyn Rodrigues
2019-12-12 22:46 ` Dave Chinner
2019-12-12 0:30 ` [PATCH 5/8] fs: Remove dio_end_io() Goldwyn Rodrigues
2019-12-12 9:50 ` Christoph Hellwig
2019-12-12 0:30 ` [PATCH 6/8] btrfs: Wait for extent bits to release page Goldwyn Rodrigues
2019-12-12 0:30 ` [PATCH 7/8] btrfs: Use iomap_end() instead of btrfs_dio_data Goldwyn Rodrigues
2019-12-12 9:52 ` Christoph Hellwig
2019-12-12 0:30 ` [PATCH 8/8] btrfs: remove BTRFS_INODE_READDIO_NEED_LOCK Goldwyn Rodrigues
2019-12-12 8:53 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212095044.GD15977@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).