From: Al Viro <viro@zeniv.linux.org.uk>
To: qiwuchen55@gmail.com
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [RESEND PATCH] fput: Use unbound workqueue for scheduling delayed fput works
Date: Tue, 17 Dec 2019 15:30:45 +0000 [thread overview]
Message-ID: <20191217153045.GZ4203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1576595472-27341-1-git-send-email-qiwuchen55@gmail.com>
On Tue, Dec 17, 2019 at 11:11:12PM +0800, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
>
> There is a potential starvation that the number of delayed fput works
> increase rapidly if task exit storm or fs unmount issue happens.
Err... Details, please, ideally along with a reproducer. In particular,
I would like to understand what does any of that have to do with umount.
Or to task exits, for that matter - exit_files() is called before
exit_task_work(), so you shouldn't normally be seeing task_work_add()
failures when files get closed on exit(2)...
If you are really observing such problems, it might be worth looking
into the underlying situation - something odd appears to be going
on and I'd rather understand what it is.
prev parent reply other threads:[~2019-12-17 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 15:11 [RESEND PATCH] fput: Use unbound workqueue for scheduling delayed fput works qiwuchen55
2019-12-17 15:30 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217153045.GZ4203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chenqiwu@xiaomi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qiwuchen55@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).