From: Christoph Hellwig <hch@infradead.org>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-btrfs@vger.kernel.org, hch@infradead.org,
darrick.wong@oracle.com, fdmanana@kernel.org, nborisov@suse.com,
dsterba@suse.cz, jthumshirn@suse.de,
linux-fsdevel@vger.kernel.org,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 3/8] iomap: Move lockdep_assert_held() to iomap_dio_rw() calls
Date: Sat, 21 Dec 2019 05:42:23 -0800 [thread overview]
Message-ID: <20191221134223.GA23294@infradead.org> (raw)
In-Reply-To: <20191221134118.GA17355@infradead.org>
On Sat, Dec 21, 2019 at 05:41:18AM -0800, Christoph Hellwig wrote:
> On Fri, Dec 13, 2019 at 01:57:45PM -0600, Goldwyn Rodrigues wrote:
> > From: Goldwyn Rodrigues <rgoldwyn@suse.com>
> >
> > Filesystems such as btrfs can perform direct I/O without holding the
> > inode->i_rwsem in some of the cases like writing within i_size.
> > So, remove the check for lockdep_assert_held() in iomap_dio_rw()
>
> As said last time: in the callers the assert is completely pointless,
> as it is always very close to taking the lock. This was just intended
> to deal with callers not adhering to the iomap_dio_rw calling
> conventins, and moving the assert to the calllers doesn't help with
> that at all.
And the actual patch even does that, it just is the commit log that
doesn't match it..
next prev parent reply other threads:[~2019-12-21 13:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 19:57 [PATCH 0/8 v6] btrfs direct-io using iomap Goldwyn Rodrigues
2019-12-13 19:57 ` [PATCH 1/8] fs: Export generic_file_buffered_read() Goldwyn Rodrigues
2019-12-13 19:57 ` [PATCH 2/8] iomap: add a filesystem hook for direct I/O bio submission Goldwyn Rodrigues
2019-12-14 0:31 ` Darrick J. Wong
2019-12-18 2:02 ` Darrick J. Wong
2019-12-13 19:57 ` [PATCH 3/8] iomap: Move lockdep_assert_held() to iomap_dio_rw() calls Goldwyn Rodrigues
2019-12-14 0:32 ` Darrick J. Wong
2019-12-18 2:04 ` Darrick J. Wong
2019-12-21 13:41 ` Christoph Hellwig
2019-12-21 13:42 ` Christoph Hellwig [this message]
2019-12-21 18:02 ` Darrick J. Wong
2019-12-13 19:57 ` [PATCH 4/8] btrfs: Switch to iomap_dio_rw() for dio Goldwyn Rodrigues
2019-12-21 14:42 ` Christoph Hellwig
2020-01-02 18:01 ` Goldwyn Rodrigues
2020-01-07 17:23 ` Christoph Hellwig
2020-01-07 11:59 ` Goldwyn Rodrigues
2020-01-07 17:21 ` Christoph Hellwig
2019-12-13 19:57 ` [PATCH 5/8] fs: Remove dio_end_io() Goldwyn Rodrigues
2019-12-13 19:57 ` [PATCH 6/8] btrfs: Wait for extent bits to release page Goldwyn Rodrigues
2019-12-13 19:57 ` [PATCH 7/8] btrfs: Use ->iomap_end() instead of btrfs_dio_data Goldwyn Rodrigues
2019-12-13 19:57 ` [PATCH 8/8] btrfs: remove BTRFS_INODE_READDIO_NEED_LOCK Goldwyn Rodrigues
2019-12-16 0:01 ` [PATCH 0/8 v6] btrfs direct-io using iomap Nikolay Borisov
2019-12-16 12:41 ` Goldwyn Rodrigues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191221134223.GA23294@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).