linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Alexey Gladkov <gladkov.alexey@gmail.com>
Cc: kbuild-all@lists.01.org, LKML <linux-kernel@vger.kernel.org>,
	Kernel Hardening <kernel-hardening@lists.openwall.com>,
	Linux API <linux-api@vger.kernel.org>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	Linux Security Module <linux-security-module@vger.kernel.org>,
	Akinobu Mita <akinobu.mita@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Alexey Gladkov <gladkov.alexey@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Lutomirski <luto@kernel.org>,
	Daniel Micay <danielmicay@gmail.com>,
	Djalal Harouni <tixxdz@gmail.com>,
	"Dmitry V . Levin" <ldv@altlinux.org>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ingo Molnar <mingo@kernel.org>,
	"J . Bruce Fields" <bfields@fieldses.org>,
	Jeff Layton <jlayton@poochiereds.net>,
	Jonathan Corbet <corbet@lwn.net>,
	Kees Cook <keescook@chromium.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Oleg Nesterov <oleg@redhat.com>,
	Solar Designer <solar@openwall.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v6 09/10] proc: add option to mount only a pids subset
Date: Thu, 26 Dec 2019 07:08:46 +0800	[thread overview]
Message-ID: <201912260752.HesRrecx%lkp@intel.com> (raw)
In-Reply-To: <20191225125151.1950142-10-gladkov.alexey@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2340 bytes --]

Hi Alexey,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linux/master]
[cannot apply to lwn/docs-next linus/master v5.5-rc3 next-20191220]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Alexey-Gladkov/proc-modernize-proc-to-support-multiple-private-instances/20191226-060818
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1522d9da40bdfe502c91163e6d769332897201fa
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/sunrpc/stats.h:13:0,
                    from include/linux/sunrpc/clnt.h:22,
                    from include/linux/nfs_fs.h:32,
                    from init/do_mounts.c:23:
   include/linux/proc_fs.h:162:47: warning: 'struct proc_info_fs' declared inside parameter list will not be visible outside of this definition or declaration
    static inline void proc_fs_set_pid_gid(struct proc_info_fs *fs_info, kgid_t gid)
                                                  ^~~~~~~~~~~~
   include/linux/proc_fs.h: In function 'proc_fs_pidonly':
>> include/linux/proc_fs.h:168:9: warning: 'return' with a value, in function returning void
     return PROC_PIDONLY_OFF;
            ^~~~~~~~~~~~~~~~
   include/linux/proc_fs.h:166:20: note: declared here
    static inline void proc_fs_pidonly(struct proc_fs_info *fs_info)
                       ^~~~~~~~~~~~~~~

vim +/return +168 include/linux/proc_fs.h

   161	
 > 162	static inline void proc_fs_set_pid_gid(struct proc_info_fs *fs_info, kgid_t gid)
   163	{
   164	}
   165	
   166	static inline void proc_fs_pidonly(struct proc_fs_info *fs_info)
   167	{
 > 168		return PROC_PIDONLY_OFF;
   169	}
   170	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 7285 bytes --]

  reply	other threads:[~2019-12-25 23:09 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-25 12:51 [PATCH v6 00/10] proc: modernize proc to support multiple private instances Alexey Gladkov
2019-12-25 12:51 ` [PATCH v6 01/10] proc: Rename struct proc_fs_info to proc_fs_opts Alexey Gladkov
2019-12-25 12:51 ` [PATCH v6 02/10] proc: add proc_fs_info struct to store proc information Alexey Gladkov
2019-12-25 12:51 ` [PATCH v6 03/10] proc: move /proc/{self|thread-self} dentries to proc_fs_info Alexey Gladkov
2019-12-25 12:51 ` [PATCH v6 04/10] proc: move hide_pid, pid_gid from pid_namespace " Alexey Gladkov
2019-12-25 12:51 ` [PATCH v6 05/10] proc: add helpers to set and get proc hidepid and gid mount options Alexey Gladkov
2019-12-25 23:06   ` kbuild test robot
2019-12-25 12:51 ` [PATCH v6 06/10] proc: support mounting procfs instances inside same pid namespace Alexey Gladkov
2019-12-25 12:51 ` [PATCH v6 07/10] proc: flush task dcache entries from all procfs instances Alexey Gladkov
2019-12-30 22:03   ` J Freyensee
2020-01-03  8:56     ` Alexey Gladkov
2019-12-25 12:51 ` [PATCH v6 08/10] proc: instantiate only pids that we can ptrace on 'hidepid=3' mount option Alexey Gladkov
2019-12-25 12:51 ` [PATCH v6 09/10] proc: add option to mount only a pids subset Alexey Gladkov
2019-12-25 23:08   ` kbuild test robot [this message]
2019-12-25 12:51 ` [PATCH v6 10/10] docs: proc: add documentation for "hidepid=3" and "pidonly" options and new mount behavior Alexey Gladkov
2020-01-06 15:15 ` [PATCH v6 00/10] proc: modernize proc to support multiple private instances Alexey Dobriyan
2020-01-08 10:37   ` Alexey Gladkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201912260752.HesRrecx%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=adobriyan@gmail.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bfields@fieldses.org \
    --cc=corbet@lwn.net \
    --cc=danielmicay@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=gladkov.alexey@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jlayton@poochiereds.net \
    --cc=kbuild-all@lists.01.org \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=ldv@altlinux.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=sfr@canb.auug.org.au \
    --cc=solar@openwall.com \
    --cc=tixxdz@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).