* [PATCH] fs: posix-acl.c: Fix warnings
[not found] <20191227010035.854913-1-dwlsalmeida@gmail.com>
@ 2019-12-27 1:00 ` Daniel W. S. Almeida
2019-12-27 1:00 ` [PATCH] fs: seq_file.c: " Daniel W. S. Almeida
1 sibling, 0 replies; 2+ messages in thread
From: Daniel W. S. Almeida @ 2019-12-27 1:00 UTC (permalink / raw)
To: viro
Cc: Daniel W. S. Almeida, linux-kernel, skhan, linux-kernel-mentees,
linux-fsdevel
From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Fix the following warning
/fs/posix_acl.c:636: WARNING: Inline emphasis start-string without end-string.
By escaping a character.
Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
---
fs/posix_acl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index 84ad1c90d535..cb25966c6881 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -634,7 +634,7 @@ EXPORT_SYMBOL_GPL(posix_acl_create);
*
* Update the file mode when setting an ACL: compute the new file permission
* bits based on the ACL. In addition, if the ACL is equivalent to the new
- * file mode, set *acl to NULL to indicate that no ACL should be set.
+ * file mode, set \*acl to NULL to indicate that no ACL should be set.
*
* As with chmod, clear the setgit bit if the caller is not in the owning group
* or capable of CAP_FSETID (see inode_change_ok).
@@ -743,12 +743,12 @@ posix_acl_from_xattr(struct user_namespace *user_ns,
return ERR_PTR(-EINVAL);
if (count == 0)
return NULL;
-
+
acl = posix_acl_alloc(count, GFP_NOFS);
if (!acl)
return ERR_PTR(-ENOMEM);
acl_e = acl->a_entries;
-
+
for (end = entry + count; entry != end; acl_e++, entry++) {
acl_e->e_tag = le16_to_cpu(entry->e_tag);
acl_e->e_perm = le16_to_cpu(entry->e_perm);
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] fs: seq_file.c: Fix warnings
[not found] <20191227010035.854913-1-dwlsalmeida@gmail.com>
2019-12-27 1:00 ` [PATCH] fs: posix-acl.c: Fix warnings Daniel W. S. Almeida
@ 2019-12-27 1:00 ` Daniel W. S. Almeida
1 sibling, 0 replies; 2+ messages in thread
From: Daniel W. S. Almeida @ 2019-12-27 1:00 UTC (permalink / raw)
To: viro
Cc: Daniel W. S. Almeida, linux-kernel, skhan, linux-kernel-mentees,
linux-fsdevel
From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
Fix the following warnings:
fs/seq_file.c:40: WARNING: Inline strong start-string without end-string.
fs/seq_file.c:40: WARNING: Inline strong start-string without end-string.
fs/seq_file.c:40: WARNING: Inline strong start-string without end-string.
fs/seq_file.c:40: WARNING: Inline strong start-string without end-string
By escaping the parenthesis in the affected line. Line breaks were added
for clarity.
Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
---
fs/seq_file.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/fs/seq_file.c b/fs/seq_file.c
index 1600034a929b..aad4354ceeb0 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -38,10 +38,18 @@ static void *seq_buf_alloc(unsigned long size)
* @op: method table describing the sequence
*
* seq_open() sets @file, associating it with a sequence described
- * by @op. @op->start() sets the iterator up and returns the first
- * element of sequence. @op->stop() shuts it down. @op->next()
- * returns the next element of sequence. @op->show() prints element
- * into the buffer. In case of error ->start() and ->next() return
+ * by @op.
+ *
+ * @op->start\(\) sets the iterator up and returns the first
+ * element of sequence.
+ *
+ * @op->stop\(\) shuts it down.
+ *
+ * @op->next\(\) returns the next element of sequence.
+ *
+ * @op->show\(\) prints element into the buffer.
+ *
+ * In case of error ->start() and ->next() return
* ERR_PTR(error). In the end of sequence they return %NULL. ->show()
* returns 0 in case of success and negative number in case of error.
* Returning SEQ_SKIP means "discard this element and move on".
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread