From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C10E2C2D0CE for ; Fri, 27 Dec 2019 11:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9707320828 for ; Fri, 27 Dec 2019 11:37:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="wA9y8xWm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727126AbfL0LhC (ORCPT ); Fri, 27 Dec 2019 06:37:02 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:35213 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727028AbfL0LhB (ORCPT ); Fri, 27 Dec 2019 06:37:01 -0500 Received: by mail-wm1-f68.google.com with SMTP id p17so8069092wmb.0 for ; Fri, 27 Dec 2019 03:36:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=vYLFB/uLWChvEa1SjgamsZ5n2OMiY1NO7RNKVGxv64I=; b=wA9y8xWm9ulX0jcjr/Q4fMa+CIjLe1WNOnrKOG6FQ86CpFV+mqxMkBOftKML0d6v/J rCxUMWOO2JA/WJCAQuwBzCkWnauR8fPiOuXQXFeuR40G4SNS0oPJPgZ1GxcPUloGPyoc rTAqTUplNF/TJVhhOC3Qn9Zo61xTe4hukSBt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=vYLFB/uLWChvEa1SjgamsZ5n2OMiY1NO7RNKVGxv64I=; b=KPtWuHLgpfW4m429ZFQi5T+pto6lErnvP7aZ/lKweZXwqR6Z8SStJgz+ZGus0VmGp5 sWZvKssqV6c7xWiUyBsbgii76QQIT/YpCagoHK6LA/SR0gUoHhYS8UX2UFlxtY2wn0VZ kH2DSmwLma4dJvxId2Wrnu/Qf7Xnjue2Ok0yY5khxu05IDl6O+1gC/+Eo2WdOkqccfwH 9S0OJNbhYlcDBBKgvqkMMLIHZKFSUh1jZf7dX6HXI4pcmvBCDHSnu0ftbdypFIbYzj2d 5i9HRKHOXrih8FGUSc8qp8MpvZe3Eg47B8O7d0YoTh779CSwVQPsID3DjZilCOIbmItT IUuw== X-Gm-Message-State: APjAAAXOFrvZJWxrkibbGW48M59yNBksvTzL/+ePORaph2TvqQXJL9uV chdi1pDyvv/qyW24xSiqni9o7Y+hLkQ= X-Google-Smtp-Source: APXvYqxdWbM0VFPfavkOQ7Syvg3XtT7I6sj7u2hO46ItzR9trEv+MnBpW96YfNZeXSYp+QJnuqLO4A== X-Received: by 2002:a1c:8095:: with SMTP id b143mr18803322wmd.7.1577446618889; Fri, 27 Dec 2019 03:36:58 -0800 (PST) Received: from localhost (host-92-23-123-10.as13285.net. [92.23.123.10]) by smtp.gmail.com with ESMTPSA id v83sm11119135wmg.16.2019.12.27.03.36.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2019 03:36:58 -0800 (PST) Date: Fri, 27 Dec 2019 11:36:56 +0000 From: Chris Down To: Amir Goldstein Cc: linux-fsdevel , Al Viro , Matthew Wilcox , Jeff Layton , Johannes Weiner , Tejun Heo , linux-kernel , kernel-team@fb.com, "zhengbin (A)" Subject: Re: [PATCH] fs: inode: Recycle inodenum from volatile inode slabs Message-ID: <20191227113656.GA442424@chrisdown.name> References: <20191226154808.GA418948@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Amir Goldstein writes: >> - bpffs >> - configfs >> - debugfs >> - efivarfs >> - hugetlbfs >> - ramfs >> - tmpfs >> > >I'm confused about this list. >I suggested to convert tmpfs and hugetlbfs because they use a private >inode cache pool, therefore, you can know for sure that a recycled i_ino >was allocated by get_next_ino(). Oh, right. I mistakenly thought alloc_inode was somehow sb-specific and missed that these don't have any super_operations->alloc_inode :-) I'll reduce it just to those with this explicitly set. >I'd go even further to say that introducing a generic helper for this sort >of thing is asking for trouble. It is best to keep the recycle logic well within >the bounds of the specific filesystem driver, which is the owner of the >private inode cache and the responsible for allocating ino numbers in >this pool. Thanks, considering that alloc_inode isn't sb-dependent like I thought, that definitely sounds reasonable. I'll do that and send v3 then. Thanks, Chris