From: "Pali Rohár" <pali.rohar@gmail.com>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu, hch@lst.de,
sj1557.seo@samsung.com, linkinjeon@gmail.com
Subject: Re: [PATCH v8 02/13] exfat: add super block operations
Date: Sun, 29 Dec 2019 14:55:48 +0100 [thread overview]
Message-ID: <20191229135548.qu3i3zglezlnndds@pali> (raw)
In-Reply-To: <20191220062419.23516-3-namjae.jeon@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1381 bytes --]
On Friday 20 December 2019 01:24:08 Namjae Jeon wrote:
> This adds the implementation of superblock operations for exfat.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> ---
> fs/exfat/super.c | 732 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 732 insertions(+)
> create mode 100644 fs/exfat/super.c
>
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c
> new file mode 100644
> index 000000000000..07687997c7f8
> --- /dev/null
> +++ b/fs/exfat/super.c
...
> +
> + if (le16_to_cpu(p_bpb->bsx.vol_flags) & VOL_DIRTY) {
> + sbi->vol_flag |= VOL_DIRTY;
> + exfat_msg(sb, KERN_WARNING,
> + "Volume was not properly unmounted. Some data may be corrupt. Please run fsck.");
Hello, do you have some pointers which fsck tool should user run in this
case?
> + }
> +
> + ret = exfat_create_upcase_table(sb);
> + if (ret) {
> + exfat_msg(sb, KERN_ERR, "failed to load upcase table");
> + goto free_bh;
> + }
> +
> + /* allocate-bitmap is only for exFAT */
It looks like that this comment is relict from previous version which
had also FAT32 code included...
> + ret = exfat_load_bitmap(sb);
> + if (ret) {
> + exfat_msg(sb, KERN_ERR, "failed to load alloc-bitmap");
> + goto free_upcase_table;
> + }
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2019-12-29 13:55 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191220062731epcas1p475b8da9288b08c87e474a0c4e88ce219@epcas1p4.samsung.com>
2019-12-20 6:24 ` [PATCH v8 00/13] add the latest exfat driver Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2019-12-29 14:11 ` Pali Rohár
2019-12-31 13:46 ` Namjae Jeon
2020-01-02 11:06 ` Pali Rohár
2020-01-02 11:11 ` Namjae Jeon
2019-12-31 13:25 ` Markus Elfring
2019-12-31 14:05 ` Markus Elfring
2019-12-20 6:24 ` [PATCH v8 02/13] exfat: add super block operations Namjae Jeon
2019-12-29 13:40 ` Pali Rohár
2020-01-02 6:06 ` Namjae Jeon
2020-01-02 8:30 ` Pali Rohár
2020-01-02 13:13 ` Namjae Jeon
2020-01-02 13:16 ` Pali Rohár
2020-01-02 13:41 ` Namjae Jeon
2020-01-02 14:13 ` Pali Rohár
2019-12-29 13:55 ` Pali Rohár [this message]
2019-12-31 13:32 ` Namjae Jeon
2020-01-08 19:55 ` Arnd Bergmann
2020-01-09 23:36 ` Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 03/13] exfat: add inode operations Namjae Jeon
2019-12-29 14:15 ` Pali Rohár
2019-12-31 13:53 ` Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 04/13] exfat: add directory operations Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 05/13] exfat: add file operations Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 06/13] exfat: add exfat entry operations Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 07/13] exfat: add bitmap operations Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 08/13] exfat: add exfat cache Namjae Jeon
2019-12-29 14:23 ` Pali Rohár
2019-12-31 13:52 ` Namjae Jeon
2020-01-02 10:19 ` [v8 " Markus Elfring
2020-01-08 18:08 ` Pali Rohár
2020-01-08 18:46 ` Christoph Hellwig
2020-01-08 19:01 ` Pali Rohár
2019-12-20 6:24 ` [PATCH v8 09/13] exfat: add misc operations Namjae Jeon
2019-12-29 14:00 ` Pali Rohár
2019-12-31 13:34 ` Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 10/13] exfat: add nls operations Namjae Jeon
2019-12-31 14:23 ` Markus Elfring
2019-12-31 18:01 ` Joe Perches
2020-01-02 9:56 ` Markus Elfring
2019-12-20 6:24 ` [PATCH v8 11/13] exfat: add Kconfig and Makefile Namjae Jeon
2019-12-20 6:24 ` [PATCH v8 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2019-12-23 22:17 ` kbuild test robot
2019-12-20 6:24 ` [PATCH v8 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
2019-12-31 13:00 ` [PATCH v8 00/13] add the latest exfat driver Markus Elfring
2019-12-31 15:14 ` Matthew Wilcox
2019-12-31 23:56 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191229135548.qu3i3zglezlnndds@pali \
--to=pali.rohar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox