From: kbuild test robot <lkp@intel.com>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, gregkh@linuxfoundation.org,
valdis.kletnieks@vt.edu, hch@lst.de, sj1557.seo@samsung.com,
linkinjeon@gmail.com, pali.rohar@gmail.com,
Namjae Jeon <namjae.jeon@samsung.com>
Subject: Re: [PATCH v9 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile
Date: Sat, 4 Jan 2020 13:22:19 +0800 [thread overview]
Message-ID: <202001041325.EBcsVwI1%lkp@intel.com> (raw)
In-Reply-To: <20200102082036.29643-13-namjae.jeon@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 6354 bytes --]
Hi Namjae,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linux/master]
[also build test ERROR on hch-configfs/for-next linus/master v5.5-rc4 next-20191219]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Namjae-Jeon/add-the-latest-exfat-driver/20200104-035709
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1522d9da40bdfe502c91163e6d769332897201fa
config: c6x-allyesconfig (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
fs/exfat/misc.c: In function 'exfat_time_unix2fat':
>> fs/exfat/misc.c:157:16: error: 'UNIX_SECS_2108' undeclared (first use in this function); did you mean 'UNIX_SECS_1980'?
if (second >= UNIX_SECS_2108) {
^~~~~~~~~~~~~~
UNIX_SECS_1980
fs/exfat/misc.c:157:16: note: each undeclared identifier is reported only once for each function it appears in
vim +157 fs/exfat/misc.c
25430145db94f9 Namjae Jeon 2020-01-02 131
25430145db94f9 Namjae Jeon 2020-01-02 132 #define TIMEZONE_CUR_OFFSET() ((sys_tz.tz_minuteswest / (-15)) & 0x7F)
25430145db94f9 Namjae Jeon 2020-01-02 133 /* Convert linear UNIX date to a FAT time/date pair. */
25430145db94f9 Namjae Jeon 2020-01-02 134 void exfat_time_unix2fat(struct exfat_sb_info *sbi, struct timespec64 *ts,
25430145db94f9 Namjae Jeon 2020-01-02 135 struct exfat_date_time *tp)
25430145db94f9 Namjae Jeon 2020-01-02 136 {
25430145db94f9 Namjae Jeon 2020-01-02 137 time_t second = ts->tv_sec;
25430145db94f9 Namjae Jeon 2020-01-02 138 time_t day, month, year;
25430145db94f9 Namjae Jeon 2020-01-02 139 time_t ld; /* leap day */
25430145db94f9 Namjae Jeon 2020-01-02 140
25430145db94f9 Namjae Jeon 2020-01-02 141 /* Treats as local time with proper time */
25430145db94f9 Namjae Jeon 2020-01-02 142 second -= sys_tz.tz_minuteswest * SECS_PER_MIN;
25430145db94f9 Namjae Jeon 2020-01-02 143 tp->timezone.valid = 1;
25430145db94f9 Namjae Jeon 2020-01-02 144 tp->timezone.off = TIMEZONE_CUR_OFFSET();
25430145db94f9 Namjae Jeon 2020-01-02 145
25430145db94f9 Namjae Jeon 2020-01-02 146 /* Jan 1 GMT 00:00:00 1980. But what about another time zone? */
25430145db94f9 Namjae Jeon 2020-01-02 147 if (second < UNIX_SECS_1980) {
25430145db94f9 Namjae Jeon 2020-01-02 148 tp->second = 0;
25430145db94f9 Namjae Jeon 2020-01-02 149 tp->minute = 0;
25430145db94f9 Namjae Jeon 2020-01-02 150 tp->hour = 0;
25430145db94f9 Namjae Jeon 2020-01-02 151 tp->day = 1;
25430145db94f9 Namjae Jeon 2020-01-02 152 tp->month = 1;
25430145db94f9 Namjae Jeon 2020-01-02 153 tp->year = 0;
25430145db94f9 Namjae Jeon 2020-01-02 154 return;
25430145db94f9 Namjae Jeon 2020-01-02 155 }
25430145db94f9 Namjae Jeon 2020-01-02 156
25430145db94f9 Namjae Jeon 2020-01-02 @157 if (second >= UNIX_SECS_2108) {
25430145db94f9 Namjae Jeon 2020-01-02 158 tp->second = 59;
25430145db94f9 Namjae Jeon 2020-01-02 159 tp->minute = 59;
25430145db94f9 Namjae Jeon 2020-01-02 160 tp->hour = 23;
25430145db94f9 Namjae Jeon 2020-01-02 161 tp->day = 31;
25430145db94f9 Namjae Jeon 2020-01-02 162 tp->month = 12;
25430145db94f9 Namjae Jeon 2020-01-02 163 tp->year = 127;
25430145db94f9 Namjae Jeon 2020-01-02 164 return;
25430145db94f9 Namjae Jeon 2020-01-02 165 }
25430145db94f9 Namjae Jeon 2020-01-02 166
25430145db94f9 Namjae Jeon 2020-01-02 167 day = second / SECS_PER_DAY - DAYS_DELTA_DECADE;
25430145db94f9 Namjae Jeon 2020-01-02 168 year = day / 365;
25430145db94f9 Namjae Jeon 2020-01-02 169
25430145db94f9 Namjae Jeon 2020-01-02 170 MAKE_LEAP_YEAR(ld, year);
25430145db94f9 Namjae Jeon 2020-01-02 171 if (year * 365 + ld > day)
25430145db94f9 Namjae Jeon 2020-01-02 172 year--;
25430145db94f9 Namjae Jeon 2020-01-02 173
25430145db94f9 Namjae Jeon 2020-01-02 174 MAKE_LEAP_YEAR(ld, year);
25430145db94f9 Namjae Jeon 2020-01-02 175 day -= year * 365 + ld;
25430145db94f9 Namjae Jeon 2020-01-02 176
25430145db94f9 Namjae Jeon 2020-01-02 177 if (IS_LEAP_YEAR(year) && day == accum_days_in_year[3]) {
25430145db94f9 Namjae Jeon 2020-01-02 178 month = 2;
25430145db94f9 Namjae Jeon 2020-01-02 179 } else {
25430145db94f9 Namjae Jeon 2020-01-02 180 if (IS_LEAP_YEAR(year) && day > accum_days_in_year[3])
25430145db94f9 Namjae Jeon 2020-01-02 181 day--;
25430145db94f9 Namjae Jeon 2020-01-02 182 for (month = 1; month < 12; month++) {
25430145db94f9 Namjae Jeon 2020-01-02 183 if (accum_days_in_year[month + 1] > day)
25430145db94f9 Namjae Jeon 2020-01-02 184 break;
25430145db94f9 Namjae Jeon 2020-01-02 185 }
25430145db94f9 Namjae Jeon 2020-01-02 186 }
25430145db94f9 Namjae Jeon 2020-01-02 187 day -= accum_days_in_year[month];
25430145db94f9 Namjae Jeon 2020-01-02 188
25430145db94f9 Namjae Jeon 2020-01-02 189 tp->second = second % SECS_PER_MIN;
25430145db94f9 Namjae Jeon 2020-01-02 190 tp->minute = (second / SECS_PER_MIN) % 60;
25430145db94f9 Namjae Jeon 2020-01-02 191 tp->hour = (second / SECS_PER_HOUR) % 24;
25430145db94f9 Namjae Jeon 2020-01-02 192 tp->day = day + 1;
25430145db94f9 Namjae Jeon 2020-01-02 193 tp->month = month;
25430145db94f9 Namjae Jeon 2020-01-02 194 tp->year = year;
25430145db94f9 Namjae Jeon 2020-01-02 195 }
25430145db94f9 Namjae Jeon 2020-01-02 196
:::::: The code at line 157 was first introduced by commit
:::::: 25430145db94f9ef1c017b0b2e3f4729888576d7 exfat: add misc operations
:::::: TO: Namjae Jeon <namjae.jeon@samsung.com>
:::::: CC: 0day robot <lkp@intel.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 50705 bytes --]
next prev parent reply other threads:[~2020-01-04 5:23 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200102082359epcas1p2aa1eca9729a6ec54ec3b8140615dca6e@epcas1p2.samsung.com>
2020-01-02 8:20 ` [PATCH v9 00/13] add the latest exfat driver Namjae Jeon
[not found] ` <CGME20200102082400epcas1p4cd0ad14967bd8d231fc0efcede8bd99c@epcas1p4.samsung.com>
2020-01-02 8:20 ` [PATCH v9 01/13] exfat: add in-memory and on-disk structures and headers Namjae Jeon
2020-01-08 17:08 ` Christoph Hellwig
2020-01-09 22:43 ` Namjae Jeon
[not found] ` <CGME20200102082401epcas1p2f33f3c11ecedabff2165ba216854d8fe@epcas1p2.samsung.com>
2020-01-02 8:20 ` [PATCH v9 02/13] exfat: add super block operations Namjae Jeon
2020-01-08 17:21 ` Christoph Hellwig
2020-01-09 23:21 ` Namjae Jeon
[not found] ` <CGME20200102082402epcas1p47cdc0873473f99c5d81f56865bb94abc@epcas1p4.samsung.com>
2020-01-02 8:20 ` [PATCH v9 03/13] exfat: add inode operations Namjae Jeon
2020-01-08 17:50 ` Christoph Hellwig
2020-01-09 23:23 ` Namjae Jeon
[not found] ` <CGME20200102082402epcas1p22cdd763b3c72166c0a91f9ba8db6a9b8@epcas1p2.samsung.com>
2020-01-02 8:20 ` [PATCH v9 04/13] exfat: add directory operations Namjae Jeon
2020-01-08 17:52 ` Christoph Hellwig
[not found] ` <CGME20200102082403epcas1p432813ab4fd8ed07075e89e48a0ce34d7@epcas1p4.samsung.com>
2020-01-02 8:20 ` [PATCH v9 05/13] exfat: add file operations Namjae Jeon
2020-01-08 17:56 ` Christoph Hellwig
[not found] ` <CGME20200102082404epcas1p4a28c34799df317165ddf8bd5a0b433e9@epcas1p4.samsung.com>
2020-01-02 8:20 ` [PATCH v9 06/13] exfat: add exfat entry operations Namjae Jeon
2020-01-08 18:00 ` Christoph Hellwig
2020-01-09 23:24 ` Namjae Jeon
[not found] ` <CGME20200102082405epcas1p41dd62d00104cb0daa4fe85641cb8ee22@epcas1p4.samsung.com>
2020-01-02 8:20 ` [PATCH v9 07/13] exfat: add bitmap operations Namjae Jeon
2020-01-08 18:01 ` Christoph Hellwig
[not found] ` <CGME20200102082405epcas1p160f24165fc8ae8f51080e75bb585e0c7@epcas1p1.samsung.com>
2020-01-02 8:20 ` [PATCH v9 08/13] exfat: add exfat cache Namjae Jeon
2020-01-08 18:02 ` Christoph Hellwig
[not found] ` <CGME20200102082406epcas1p268f260d90213bdaabee25a7518f86625@epcas1p2.samsung.com>
2020-01-02 8:20 ` [PATCH v9 09/13] exfat: add misc operations Namjae Jeon
2020-01-02 9:19 ` Pali Rohár
2020-01-02 11:30 ` Namjae Jeon
2020-01-02 11:40 ` Pali Rohár
2020-01-03 18:36 ` Pali Rohár
2020-01-03 23:28 ` Namjae Jeon
2020-01-08 18:03 ` Christoph Hellwig
2020-01-08 19:40 ` Arnd Bergmann
2020-01-09 23:32 ` Namjae Jeon
[not found] ` <CGME20200102082407epcas1p4cf10cd3d0ca2903707ab01b1cc523a05@epcas1p4.samsung.com>
2020-01-02 8:20 ` [PATCH v9 10/13] exfat: add nls operations Namjae Jeon
2020-01-02 13:55 ` Pali Rohár
2020-01-03 7:06 ` Namjae Jeon
2020-01-03 8:44 ` Pali Rohár
2020-01-02 14:20 ` Pali Rohár
2020-01-03 4:44 ` Namjae Jeon
2020-01-03 9:40 ` Pali Rohár
2020-01-03 12:31 ` Pali Rohár
2020-01-09 22:35 ` Namjae Jeon
2020-01-05 15:24 ` Pali Rohár
2020-01-05 16:51 ` Pali Rohár
2020-01-06 19:46 ` Gabriel Krisman Bertazi
2020-01-07 11:52 ` Pali Rohár
2020-01-09 22:04 ` [PATCH v9 09/13] exfat: add misc operations Valdis Klētnieks
2020-01-09 23:41 ` Namjae Jeon
2020-01-09 22:37 ` [PATCH v9 10/13] exfat: add nls operations Namjae Jeon
[not found] ` <CGME20200102082408epcas1p28d46af675103d2cd92232a4f7b712c46@epcas1p2.samsung.com>
2020-01-02 8:20 ` [PATCH v9 11/13] exfat: add Kconfig and Makefile Namjae Jeon
2020-01-02 12:53 ` Pali Rohár
[not found] ` <CGME20200102082408epcas1p194621a6aa6729011703f0c5a076a7396@epcas1p1.samsung.com>
2020-01-02 8:20 ` [PATCH v9 12/13] exfat: add exfat in fs/Kconfig and fs/Makefile Namjae Jeon
2020-01-02 12:58 ` Pali Rohár
2020-01-02 13:07 ` Namjae Jeon
2020-01-02 13:10 ` Pali Rohár
2020-01-02 14:19 ` Greg KH
2020-01-02 23:48 ` Namjae Jeon
2020-01-04 5:22 ` kbuild test robot [this message]
[not found] ` <CGME20200102082409epcas1p4210cf0ea40d23689c4a5ba18b50979cf@epcas1p4.samsung.com>
2020-01-02 8:20 ` [PATCH v9 13/13] MAINTAINERS: add exfat filesystem Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001041325.EBcsVwI1%lkp@intel.com \
--to=lkp@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kbuild-all@lists.01.org \
--cc=linkinjeon@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=pali.rohar@gmail.com \
--cc=sj1557.seo@samsung.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).