From: Al Viro <viro@zeniv.linux.org.uk>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: dcache: abstract take_name_snapshot() interface
Date: Wed, 15 Jan 2020 00:09:05 +0000 [thread overview]
Message-ID: <20200115000905.GE8904@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAOQ4uxggg4p6MD2LiAKr2dzj+35iA-B3BptXPpOjWMEUX=QbeA@mail.gmail.com>
On Wed, Jan 15, 2020 at 02:03:35AM +0200, Amir Goldstein wrote:
> Only problem I forgot about is that I need to propagate name_snapshot
> into fsnotify_move() instead of qstr (in order to snapshot it).
> That means I will need to snapshot also new_dentry in vfs_rename(), so
> I have a name_snapshot to pass into the RENAME_EXCHANGE
> fsnotify_move() hook.
>
> My current patch passes the cute &old_dentry->d_name_snap abstract
> to fsnotify_move().
>
> What shall I do about that?
>
> take_dentry_name_snapshot(&new_name, new_dentry);
> ???
Wait a sec... How long is that thing going to be using the snapshot?
And I bloody well hope that this is _not_ going to be unconditional -
having each rename() pay for *notify is a bad idea, for obvious
reasons. Details, please...
next prev parent reply other threads:[~2020-01-15 0:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 15:40 dcache: abstract take_name_snapshot() interface Amir Goldstein
2020-01-14 16:22 ` Al Viro
2020-01-14 18:06 ` Amir Goldstein
2020-01-14 19:19 ` Al Viro
2020-01-14 19:58 ` Amir Goldstein
2020-01-15 0:03 ` Amir Goldstein
2020-01-15 0:09 ` Al Viro [this message]
2020-01-15 5:44 ` Amir Goldstein
2020-01-15 5:51 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115000905.GE8904@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox