From: Al Viro <viro@zeniv.linux.org.uk>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Howells <dhowells@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v19 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support
Date: Tue, 21 Jan 2020 01:08:37 +0000 [thread overview]
Message-ID: <20200121010837.GH8904@ZenIV.linux.org.uk> (raw)
In-Reply-To: <ae314c55-905a-fce0-21aa-81c13279c004@redhat.com>
On Sat, Jan 11, 2020 at 12:46:30PM +0100, Hans de Goede wrote:
> Hi All,
>
> On 12-12-2019 15:09, Hans de Goede wrote:
> > Hello Everyone,
> >
> > Here is the 19th version of my cleaned-up / refactored version of the
> > VirtualBox shared-folder VFS driver.
> >
> > This version addresses all remarks from Al Viro's review of v18.
> >
> > I believe that this is ready for upstream merging now, if this needs
> > more work please let me know.
> >
> > Changes in v19:
> > - Misc. small code tweaks suggested by Al Viro (no functional changes)
> > - Do not increment dir_context->pos when dir_emit has returned false.
> > - Add a WARN_ON check for trying to access beyond the end of a
> > vboxsf directory buffer, this uses WARN_ON as this means the host has
> > given us corrupt data
> > - Catch the user passing the "nls" opt more then once
>
> Ping? Can I please either get some feedback on this patch, or can we get
> this merged / queued up for 5.6 please ?
Merged and pushed into #for-next
next prev parent reply other threads:[~2020-01-21 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 14:09 [PATCH v19 0/1] fs: Add VirtualBox guest shared folder (vboxsf) support Hans de Goede
2019-12-12 14:09 ` [PATCH v19] " Hans de Goede
2020-01-11 11:46 ` [PATCH v19 0/1] " Hans de Goede
2020-01-21 1:08 ` Al Viro [this message]
2020-01-21 9:09 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200121010837.GH8904@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dhowells@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).