From: Al Viro <viro@zeniv.linux.org.uk>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Gao Xiang <hsiangkao@aol.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
Daniel Rosenberg <drosen@google.com>,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH] ext4: fix race conditions in ->d_compare() and ->d_hash()
Date: Fri, 24 Jan 2020 18:31:03 +0000 [thread overview]
Message-ID: <20200124183103.GJ23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200124181253.GA41762@gmail.com>
On Fri, Jan 24, 2020 at 10:12:54AM -0800, Eric Biggers wrote:
> > Thanks for your web reference, I will look into it. I think there
> > is no worry about dentry->d_parent here because of this only one
> > dereference on dentry->d_parent.
> >
> > You could ignore my words anyway, just my little thought though.
> > Other part of the patch is ok.
> >
>
> While that does make it really unlikely to cause a real-world problem, it's
> still undefined behavior to not properly annotate a data race, it would make the
> code harder to understand as there would be no indication that there's a data
> race, and it would confuse tools that try to automatically detect data races.
> So let's keep the READ_ONCE() on d_parent.
*nod*
Note that on everything except alpha it'll generate the same code, unless
the compiler screws up an generates multiple loads. On alpha it adds
a barrier and I really don't want to sit down and check if its absense
could lead to anything unpleasant.
next prev parent reply other threads:[~2020-01-24 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 4:12 [PATCH] ext4: fix race conditions in ->d_compare() and ->d_hash() Eric Biggers
2020-01-24 5:04 ` Gao Xiang
2020-01-24 5:16 ` Eric Biggers
2020-01-24 5:27 ` Gao Xiang
2020-01-24 5:53 ` Eric Biggers
2020-01-24 5:34 ` Gao Xiang
2020-01-24 5:42 ` Eric Biggers
2020-01-24 6:15 ` Gao Xiang
2020-01-24 18:12 ` Eric Biggers
2020-01-24 18:31 ` Al Viro [this message]
2020-01-25 3:35 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124183103.GJ23230@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=drosen@google.com \
--cc=ebiggers@kernel.org \
--cc=hsiangkao@aol.com \
--cc=krisman@collabora.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).