* [linux-next:master 4531/12088] fs/fs_parser.c:191:5: sparse: sparse: symbol 'fs_param_bad_value' was not declared. Should it be static?
@ 2020-01-31 13:04 kbuild test robot
2020-01-31 13:04 ` [RFC PATCH linux-next] fs_param_bad_value() can be static kbuild test robot
0 siblings, 1 reply; 2+ messages in thread
From: kbuild test robot @ 2020-01-31 13:04 UTC (permalink / raw)
To: Al Viro; +Cc: kbuild-all, linux-fsdevel, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: c8e31a0fc39797784e4b9acae3bd2e0c7bade36e
commit: 2552e0ea2d71360b76faf1cd4ffb58019c92f817 [4531/12088] turn fs_param_is_... into functions
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-154-g1dc00f87-dirty
git checkout 2552e0ea2d71360b76faf1cd4ffb58019c92f817
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> fs/fs_parser.c:191:5: sparse: sparse: symbol 'fs_param_bad_value' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread* [RFC PATCH linux-next] fs_param_bad_value() can be static
2020-01-31 13:04 [linux-next:master 4531/12088] fs/fs_parser.c:191:5: sparse: sparse: symbol 'fs_param_bad_value' was not declared. Should it be static? kbuild test robot
@ 2020-01-31 13:04 ` kbuild test robot
0 siblings, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-01-31 13:04 UTC (permalink / raw)
To: Al Viro; +Cc: kbuild-all, linux-fsdevel, linux-kernel
Fixes: 2552e0ea2d71 ("turn fs_param_is_... into functions")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
fs_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fs_parser.c b/fs/fs_parser.c
index 834e0902fe7d3..5e059592d4b6c 100644
--- a/fs/fs_parser.c
+++ b/fs/fs_parser.c
@@ -188,7 +188,7 @@ int fs_lookup_param(struct fs_context *fc,
}
EXPORT_SYMBOL(fs_lookup_param);
-int fs_param_bad_value(struct p_log *log, struct fs_parameter *param)
+static int fs_param_bad_value(struct p_log *log, struct fs_parameter *param)
{
return inval_plog(log, "Bad value for '%s'", param->key);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-31 13:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-31 13:04 [linux-next:master 4531/12088] fs/fs_parser.c:191:5: sparse: sparse: symbol 'fs_param_bad_value' was not declared. Should it be static? kbuild test robot
2020-01-31 13:04 ` [RFC PATCH linux-next] fs_param_bad_value() can be static kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).