From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E35C761A6 for ; Mon, 17 Feb 2020 13:30:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2173C2070B for ; Mon, 17 Feb 2020 13:30:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Y6quXZyQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728686AbgBQNan (ORCPT ); Mon, 17 Feb 2020 08:30:43 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:42866 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727089AbgBQNan (ORCPT ); Mon, 17 Feb 2020 08:30:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=U11A+++4LKK51+4tdSmvbusBvC9USfeT04f6UKr3pAE=; b=Y6quXZyQbtJGHAqQouPU/RR9fr pQtX4bvumSbjtm5YOIkW/pRMaKU2libxHzttIOHrS54dg/Coan3bHDoOF+inP1AulxTy5/w7X/Rx2 DSyhT+xq98ZNuWP1+j0wIfM89xtTm9YgCm1wE8UXid3ZQFIRK6QqjtB9rhbxduG2hh3l6fFlYiFtd 7fcIiVv68pn5+YP7LMH+ldRhkQRyhTrv2hEaBKgPS5qZVitXJkg0FclicZqDPPuiPr1zv/2y+rwKP YvCVp8HN1H+G4mwIT1UpYW1zsbQ+mC0I7b2Cw+LpfHDenYSYZ6yM/25dGOJ9XrLwk131QjCz4qCbp g8TUo6hA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j3gTz-0007JC-7K; Mon, 17 Feb 2020 13:30:43 +0000 Date: Mon, 17 Feb 2020 05:30:43 -0800 From: Christoph Hellwig To: Vivek Goyal Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, dan.j.williams@intel.com, hch@infradead.org, dm-devel@redhat.com, jack@suse.cz Subject: Re: [PATCH 1/6] dax: Define a helper dax_pgoff() which takes in dax_offset as argument Message-ID: <20200217133043.GA20444@infradead.org> References: <20200212170733.8092-1-vgoyal@redhat.com> <20200212170733.8092-2-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212170733.8092-2-vgoyal@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Feb 12, 2020 at 12:07:28PM -0500, Vivek Goyal wrote: > Create a new helper dax_pgoff() which will replace bdev_dax_pgoff(). Difference > between two is that dax_pgoff() takes in "sector_t dax_offset" as an argument > instead of "struct block_device". > > dax_offset specifies any offset into dax device which should be added to > sector while calculating pgoff. > > Signed-off-by: Vivek Goyal > --- > drivers/dax/super.c | 12 ++++++++++++ > include/linux/dax.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/drivers/dax/super.c b/drivers/dax/super.c > index 0aa4b6bc5101..e9daa30e4250 100644 > --- a/drivers/dax/super.c > +++ b/drivers/dax/super.c > @@ -56,6 +56,18 @@ int bdev_dax_pgoff(struct block_device *bdev, sector_t sector, size_t size, > } > EXPORT_SYMBOL(bdev_dax_pgoff); > > +int dax_pgoff(sector_t dax_offset, sector_t sector, size_t size, pgoff_t *pgoff) Please add a kerneldoc document. I can't really make sense of what dax_offset and sector mean here and why they are passed separately. > +{ > + phys_addr_t phys_off = (dax_offset + sector) * 512; << SECTOR_SHIFT; > + > + if (pgoff) > + *pgoff = PHYS_PFN(phys_off); What is the use case of not passing a pgoff argument? > + if (phys_off % PAGE_SIZE || size % PAGE_SIZE) > + return -EINVAL; > + return 0; > +} > +EXPORT_SYMBOL(dax_pgoff); EXPORT_SYMBOL_GPL, please.