From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>,
Naohiro Aota <Naohiro.Aota@wdc.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] zonefs: fix IOCB_NOWAIT handling
Date: Mon, 24 Feb 2020 21:18:58 +0100 [thread overview]
Message-ID: <20200224201858.GA10880@lst.de> (raw)
In-Reply-To: <BYAPR04MB58169F3C3A66DCCEAA35E332E7EC0@BYAPR04MB5816.namprd04.prod.outlook.com>
On Mon, Feb 24, 2020 at 01:48:48PM +0000, Damien Le Moal wrote:
>
> The main problem with allowing IOCB_NOWAIT is that for an application that sends
> multiple write AIOs with a single io_submit(), all write AIOs after one that is
> failed with -EAGAIN will be failed with -EINVAL (not -EIO !) since they will
> have an unaligned write offset. I am wondering if that is really a problem at
> all since the application can catch the -EAGAIN and -EINVAL, indicating that the
> write stream was stopped. So maybe it is reasonable to simply allow IOCB_NOWAIT ?
I don't think supporting IOCB_NOWAIT with current zonefs is very useful.
It will be very useful once Zone Append is supported.
But more importantly my patch fixes a bug in the current zonefs
implementation. We need to fix that before 5.6 is released. Any
additional functionaity can still come later if we think that it is
useful.
next prev parent reply other threads:[~2020-02-24 20:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 14:37 [PATCH] zonefs: fix IOCB_NOWAIT handling Christoph Hellwig
2020-02-24 13:48 ` Damien Le Moal
2020-02-24 20:18 ` Christoph Hellwig [this message]
2020-02-25 9:54 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224201858.GA10880@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).