From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A16C3F2D7 for ; Wed, 4 Mar 2020 15:34:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E37E4246F9 for ; Wed, 4 Mar 2020 15:34:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="BuD4KHdd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729517AbgCDPeB (ORCPT ); Wed, 4 Mar 2020 10:34:01 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:45772 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726764AbgCDPeB (ORCPT ); Wed, 4 Mar 2020 10:34:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AnM84Lt4VRzYoXNtkX6eksI4bqOZSqh20o6IdsuWiew=; b=BuD4KHdd9KxV+XagASjNUyxfx8 aBjhqtDbYHpdch6wQ/cIcHejEC3wDHo9XWBknR0XlRGc4+S0FytzWooSZz+egQJZQbLehS3KgaS3H V96a8w5NIfrbuVAfxM8q45Qb7Bzqs5lRK8kOReBme6o+7vz3omVCndxTav4XGWxfd2KDlI/TfB8v1 WPnfzQopOml9VwXZI/BhCn/21b+orFy3IQl88Miyw12kg1K96BiyZzQGghvrld424+Q1Kz0dwJI3M UtKZltVI8b02DqOXeytBNRyo5wbFZ98IAEePC4T72B7xnxTYK9YjQoUP/0tZee3TakuGRPh7lWmln Za/ckQ5Q==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9W24-0002PM-Nb; Wed, 04 Mar 2020 15:34:00 +0000 Date: Wed, 4 Mar 2020 07:34:00 -0800 From: Matthew Wilcox To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J. Wong" Subject: Re: [PATCH] iomap: Fix writepage tracepoint pgoff Message-ID: <20200304153400.GG29971@bombadil.infradead.org> References: <20200304142259.GF29971@bombadil.infradead.org> <20200304152515.GA23148@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200304152515.GA23148@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 04, 2020 at 07:25:15AM -0800, Christoph Hellwig wrote: > On Wed, Mar 04, 2020 at 06:22:59AM -0800, Matthew Wilcox wrote: > > From: Matthew Wilcox (Oracle) > > > > page_offset() confusingly returns the number of bytes from the > > beginning of the file and not the pgoff, which the tracepoint claims > > to be returning. We're already returning the number of bytes from the > > beginning of the file in the 'offset' parameter, so correct the pgoff > > to be what was apparently intended. > > > > Fixes: 0b1b213fcf3a ("xfs: event tracing support") > > Signed-off-by: Matthew Wilcox (Oracle) > > I wonder if tracing the byte offset and just changing the name > might be more useful. But I agree that we should fix it one way or > another. I covered that -- "We're already returning the number of bytes from the beginning of the file in the 'offset' parameter, so correct the pgoff to be what was apparently intended." I mean, we could just delete the pgoff instead. Apparently nobody's using it, or they would surely have noticed.