From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9222EC3F2D7 for ; Thu, 5 Mar 2020 14:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A0B12166E for ; Thu, 5 Mar 2020 14:58:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="JtnShwmj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726162AbgCEO6b (ORCPT ); Thu, 5 Mar 2020 09:58:31 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:40086 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725963AbgCEO6b (ORCPT ); Thu, 5 Mar 2020 09:58:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qOdWZjojfTuKiVHuyqqILpTUp3oLUWDNcvu8AeOy5+g=; b=JtnShwmjXvXIZuWEpk8tiQgGhu PeYE+eqVe5g1HClFlcEK1DK8E6NQCJnPbtk0BYDofz8OHyoND5B0FrV2Dt3PbgdU2pttT5Xnui+Ew Sb6r3bT1v5ET4kJrknXnmdq/v2Uv2sxXFtmp6kDaPhak5A9OqTSzrNzEClGply/ZOnUM8DONYNSQK LQND9GbpS6b/OKUdp7CCUNNzcmmRDKBtjpM2dEJFxM5Dsu2hc6R6fZ6viAcbSJwIPj0Zi++7FT9UJ kxelG6XSySeSpJSoj2zURbvI85ashmzU01V6ckFwwusklIxCvkhtW2gIkJ6/Fu76RNOLrKvIX0C74 cXqsDqJw==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j9rxH-0002Ln-1g; Thu, 05 Mar 2020 14:58:31 +0000 Date: Thu, 5 Mar 2020 06:58:31 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig , "Darrick J. Wong" Subject: Re: [PATCH v3] iomap: Remove pgoff from tracepoints Message-ID: <20200305145831.GA8974@infradead.org> References: <20200304175429.GI29971@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200304175429.GI29971@bombadil.infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 04, 2020 at 09:54:29AM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox (Oracle) > > The 'pgoff' displayed by the tracepoints wasn't a pgoff at all; it > was a byte offset from the start of the file. We already emit that in > the form of the 'offset', so we can just remove pgoff. That means we > can remove 'page' as an argument to the tracepoint, and rename this > type of tracepoint from being a page class to being a range class. > > Fixes: 0b1b213fcf3a ("xfs: event tracing support") > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Darrick J. Wong Looks good: Reviewed-by: Christoph Hellwig