From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CF4C10DCE for ; Tue, 10 Mar 2020 20:26:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 485C421D56 for ; Tue, 10 Mar 2020 20:26:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tCkxaKUG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726315AbgCJU0O (ORCPT ); Tue, 10 Mar 2020 16:26:14 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36287 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgCJU0O (ORCPT ); Tue, 10 Mar 2020 16:26:14 -0400 Received: by mail-wm1-f68.google.com with SMTP id g62so2861614wme.1; Tue, 10 Mar 2020 13:26:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JqYk8R4UPwKS97k6zpIyj5riBjZ7GjDwEcUa5Ekupac=; b=tCkxaKUGWKNb+HTFdm5JbBkMM4KtNpMAde+z/oWZh3mOGSVZ2p5N/0MdlVGcB8K27b 3ARO+n2hD1B00XYU/Y/P9RfKsDcCWTRsIkZYDjf1fWtRuvqJJUzrfduyJbeidLDwsxJi apRYCKwT1z4pdpgXFVifYp++iYW1EHHw4fdRZUAP5VdrWn4scSsSsvpA2uYe8u3nMsx6 4gZyM6cLKDY8khJubIx5bQR1L+922dEpo4MAtMLgJQ5/GoxL814HlZTenVZeWdeTbyuE 531KTbZpXTCmUlUfmx9MDq8sCPIlcKWJDuulZy+9563ns1wcWGpLzHpEW8qlzpfBeNSL 7/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JqYk8R4UPwKS97k6zpIyj5riBjZ7GjDwEcUa5Ekupac=; b=V6wN2DPztC6sn5Or5tulihCVHS5QJYVs0I1ReTM+1D0OmVAldrKEO17JpfLcT6Yvx0 dsY85I1fAAuitKMaJdaN5JtID6Gex7Da4J7pVobcPfplDkMscJ419/8g656Y0aCCgYlQ 9Dz6BgA6Abf9nKTpcvv9tizSUdLB8LFBtRrtbQ8XjZE1Bg3BWgiy61dCWyA904sU9bYO i9W1eAGwNf/8fGoINsEN/LyhDRw64GuF1ZrM/XxD9o9ezryhWimHXMdKbZke+BcAHFaj J58rQssxwwcakkEAoUO8JPBsJBXp/zjGbHdPlfeDPD1Ei6/3KwWQAJwfJ/PmfHxyLOhL Kq8Q== X-Gm-Message-State: ANhLgQ3FZCQz9o6JnVTf8est9Memn+lzlCKBydU0wljBgvROql6dTO7/ Ht7ZVmFnAFC9eYQblqwsxL341P8= X-Google-Smtp-Source: ADFU+vvQS3dt6GEtid3fA+7d9DuJE3zKvSKgS14keG2HQAca41GrUO3nrwsCDXKWZ+MwILBlwMptqw== X-Received: by 2002:a1c:7e08:: with SMTP id z8mr3581832wmc.166.1583871972104; Tue, 10 Mar 2020 13:26:12 -0700 (PDT) Received: from avx2 ([46.53.249.42]) by smtp.gmail.com with ESMTPSA id c2sm5593845wma.39.2020.03.10.13.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 13:26:11 -0700 (PDT) Date: Tue, 10 Mar 2020 23:26:09 +0300 From: Alexey Dobriyan To: Anshuman Khandual Cc: Hugh Dickins , linux-mm@kvack.org, "David S. Miller" , Andrew Morton , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC 3/3] mm/vma: Introduce some more VMA flag wrappers Message-ID: <20200310202609.GA6287@avx2> References: <1583131666-15531-1-git-send-email-anshuman.khandual@arm.com> <1583131666-15531-4-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Mar 03, 2020 at 02:43:21PM +0530, Anshuman Khandual wrote: > On 03/03/2020 12:04 PM, Hugh Dickins wrote: > > On Mon, 2 Mar 2020, Anshuman Khandual wrote: > >> vma_is_dontdump() > >> vma_is_noreserve() > >> vma_is_special() > >> vma_is_locked() > >> vma_is_mergeable() > >> vma_is_softdirty() > >> vma_is_thp() > >> vma_is_nothp() > > Improved readability? Not to my eyes. > > As mentioned before, I dont feel strongly about patch 3/3 and will drop. Should be "const struct vm_area_struct *" anyway.