From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ECDBC10F29 for ; Tue, 17 Mar 2020 14:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6D95F20735 for ; Tue, 17 Mar 2020 14:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726908AbgCQO5r (ORCPT ); Tue, 17 Mar 2020 10:57:47 -0400 Received: from verein.lst.de ([213.95.11.211]:60355 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726781AbgCQO5r (ORCPT ); Tue, 17 Mar 2020 10:57:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 83CB168C65; Tue, 17 Mar 2020 15:57:44 +0100 (CET) Date: Tue, 17 Mar 2020 15:57:44 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Miklos Szeredi , Christoph Hellwig , Alexander Viro , linux-fsdevel Subject: Re: [PATCH] fs: move the posix_acl_fix_xattr_{to_from}_user out of xattr code Message-ID: <20200317145744.GA15941@lst.de> References: <20200221173722.538788-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Mar 03, 2020 at 02:42:50PM +0100, Andreas Gruenbacher wrote: > Miklos, > > On Fri, Feb 21, 2020 at 7:01 PM Christoph Hellwig wrote: > > There is no excuse to ever perform actions related to a specific handler > > directly from the generic xattr code as we have handler that understand > > the specific data in given attrs. As a nice sideeffect this removes > > tons of pointless boilerplate code. > > > > Signed-off-by: Christoph Hellwig > > can you please review this change from an overlayfs point of view? ping?