From: Matthew Wilcox <willy@infradead.org>
To: Vitor Massaru Iha <vitor@massaru.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
skhan@linuxfoundation.org
Subject: Re: [PATCH 2/2] xarray: Add missing blank line after declaration
Date: Tue, 17 Mar 2020 18:55:53 -0700 [thread overview]
Message-ID: <20200318015553.GG22433@bombadil.infradead.org> (raw)
In-Reply-To: <7efa62f727eb176341fc0cdfcd47c890ff424451.1584494902.git.vitor@massaru.org>
On Tue, Mar 17, 2020 at 10:43:03PM -0300, Vitor Massaru Iha wrote:
> @@ -1624,6 +1624,7 @@ static inline unsigned int xas_find_chunk(struct xa_state *xas, bool advance,
> if (XA_CHUNK_SIZE == BITS_PER_LONG) {
> if (offset < XA_CHUNK_SIZE) {
> unsigned long data = *addr & (~0UL << offset);
> +
> if (data)
> return __ffs(data);
> }
Do you seriously think this makes the function in any way more legible?
next prev parent reply other threads:[~2020-03-18 1:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 1:43 [PATCH 0/2] xarrary: Fix warnings reported by checkpatch Vitor Massaru Iha
2020-03-18 1:43 ` [PATCH 1/2] xarray: Add identifier names for function definition arguments Vitor Massaru Iha
2020-03-18 1:43 ` [PATCH 2/2] xarray: Add missing blank line after declaration Vitor Massaru Iha
2020-03-18 1:55 ` Matthew Wilcox [this message]
2020-03-18 3:01 ` Vitor Massaru Iha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318015553.GG22433@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vitor@massaru.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).