From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: yangerkun <yangerkun@huawei.com>
Cc: hch@infradead.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] iomap: fix comments in iomap_dio_rw
Date: Wed, 18 Mar 2020 08:06:32 -0700 [thread overview]
Message-ID: <20200318150632.GC256713@magnolia> (raw)
In-Reply-To: <20200318095022.5613-1-yangerkun@huawei.com>
On Wed, Mar 18, 2020 at 05:50:22PM +0800, yangerkun wrote:
> Double 'three' exists in the comments of iomap_dio_rw.
>
> Signed-off-by: yangerkun <yangerkun@huawei.com>
Looks good, will stage for 5.7...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/iomap/direct-io.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c
> index 23837926c0c5..20dde5aadcdd 100644
> --- a/fs/iomap/direct-io.c
> +++ b/fs/iomap/direct-io.c
> @@ -534,8 +534,8 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter,
>
> /*
> * We are about to drop our additional submission reference, which
> - * might be the last reference to the dio. There are three three
> - * different ways we can progress here:
> + * might be the last reference to the dio. There are three different
> + * ways we can progress here:
> *
> * (a) If this is the last reference we will always complete and free
> * the dio ourselves.
> --
> 2.17.2
>
prev parent reply other threads:[~2020-03-18 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 9:50 [PATCH] iomap: fix comments in iomap_dio_rw yangerkun
2020-03-18 9:23 ` Christoph Hellwig
2020-03-18 15:06 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318150632.GC256713@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=yangerkun@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).