From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A326C1975A for ; Wed, 25 Mar 2020 08:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2845420714 for ; Wed, 25 Mar 2020 08:40:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LmE+Tm3M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727339AbgCYIkb (ORCPT ); Wed, 25 Mar 2020 04:40:31 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:50280 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726906AbgCYIkb (ORCPT ); Wed, 25 Mar 2020 04:40:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=h5hpNPfmMzO0qwGMReM4jVIBMBMcWpn40WL8el6WfJ4=; b=LmE+Tm3MJYRXXkp5z3JzAHVGuZ ffkeBa5uRK4MHD3ABne/71XmUAFBw0V6X6Hv0mXzXkKMnd7YLgOaTU7zJMx+X+tDr3z9rZBpHlR1z aKPebzJ25am4a5foJ+qm285MD4eXsZYsRX/UY8gKgLrncXGxWLrMfujvvz2lcZDW3xoiqeDioLuy1 quXCUxq+ty/lG8giFZsvEERVF97LuFEVQ38+JLVFYOoidj3QKjnOvixkUceiljg5TqpephqA7sEPr TOzW9WWXN2UoAILIfw7LJ1/lSR3Wg+NTKpuhllCSbsovVVxFkL+xbOZyb5DtoybnqsJSHDdJu9NDg Z6k+BCcQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jH1aQ-0007C6-4n; Wed, 25 Mar 2020 08:40:30 +0000 Date: Wed, 25 Mar 2020 01:40:30 -0700 From: Christoph Hellwig To: Johannes Thumshirn , Jens Axboe Cc: linux-block , Damien Le Moal , Keith Busch , "linux-scsi @ vger . kernel . org" , "Martin K . Petersen" , "linux-fsdevel @ vger . kernel . org" , "Darrick J . Wong" , Christoph Hellwig Subject: Re: [PATCH v2 01/11] block: factor out requeue handling from dispatch code Message-ID: <20200325084030.GB11943@infradead.org> References: <20200324152454.4954-1-johannes.thumshirn@wdc.com> <20200324152454.4954-2-johannes.thumshirn@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200324152454.4954-2-johannes.thumshirn@wdc.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 25, 2020 at 12:24:44AM +0900, Johannes Thumshirn wrote: > Factor out the requeue handling from the dispatch code, this will make > subsequent addition of different requeueing schemes easier. > > Signed-off-by: Johannes Thumshirn > Reviewed-by: Christoph Hellwig Jens, can you pick this up? I think it already is a nice improvement even without the rest of the series.