From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Ritesh Harjani <riteshh@linux.ibm.com>,
linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext4: Unregister sysfs path before destroying jbd2 journal
Date: Thu, 26 Mar 2020 10:53:11 -0400 [thread overview]
Message-ID: <20200326145311.GR53396@mit.edu> (raw)
In-Reply-To: <20200318091318.GJ22684@quack2.suse.cz>
On Wed, Mar 18, 2020 at 10:13:18AM +0100, Jan Kara wrote:
> On Wed 18-03-20 11:43:01, Ritesh Harjani wrote:
> > Call ext4_unregister_sysfs(), before destroying jbd2 journal,
> > since below might cause, NULL pointer dereference issue.
> > This got reported with LTP tests.
> >
> > ext4_put_super() cat /sys/fs/ext4/loop2/journal_task
> > | ext4_attr_show();
> > ext4_jbd2_journal_destroy(); |
> > | journal_task_show()
> > | |
> > | task_pid_vnr(NULL);
> > sbi->s_journal = NULL;
> >
> > Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
>
> Yeah, makes sence. Thanks for the patch! You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
prev parent reply other threads:[~2020-03-26 14:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 6:13 [PATCH] ext4: Unregister sysfs path before destroying jbd2 journal Ritesh Harjani
2020-03-18 9:13 ` Jan Kara
2020-03-26 14:53 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326145311.GR53396@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).