From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC] iomap: Remove indirect function call
Date: Tue, 31 Mar 2020 00:46:28 -0700 [thread overview]
Message-ID: <20200331074628.GA9872@infradead.org> (raw)
In-Reply-To: <20200328155156.GS22483@bombadil.infradead.org>
On Sat, Mar 28, 2020 at 08:51:56AM -0700, Matthew Wilcox wrote:
> By splitting iomap_apply into __iomap_apply and an inline iomap_apply,
> we convert the call to 'actor' into a direct function call. I haven't
> done any performance measurements, but given the current costs of indirect
> function calls, this would seem worthwhile to me?
Hmm. Given that emount of compiler stupidity we are dealing with did
you at least look at the assembly output to see if this actually removes
the indirect call? I wouldn't be quite sure.
next prev parent reply other threads:[~2020-03-31 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-28 15:51 [RFC] iomap: Remove indirect function call Matthew Wilcox
2020-03-31 7:46 ` Christoph Hellwig [this message]
2020-03-31 13:02 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200331074628.GA9872@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).