From: "Pali Rohár" <pali@kernel.org>
To: "Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp"
<Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>,
viro@zeniv.linux.org.uk
Cc: "'linux-fsdevel@vger.kernel.org'" <linux-fsdevel@vger.kernel.org>,
"'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>,
"'namjae.jeon@samsung.com'" <namjae.jeon@samsung.com>,
"'sj1557.seo@samsung.com'" <sj1557.seo@samsung.com>
Subject: Re: [PATCH 1/4] exfat: Simplify exfat_utf8_d_hash() for code points above U+FFFF
Date: Wed, 8 Apr 2020 11:04:35 +0200 [thread overview]
Message-ID: <20200408090435.i3ufmbfinx5dyd7w@pali> (raw)
In-Reply-To: <TY1PR01MB1578892F886C62868F87663B90C00@TY1PR01MB1578.jpnprd01.prod.outlook.com>
On Wednesday 08 April 2020 03:59:06 Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp wrote:
> > So partial_name_hash() like I used it in this patch series is enough?
>
> I think partial_name_hash() is enough for 8/16/21bit characters.
Great!
Al, could you please take this patch series?
> Another point about the discrimination of 21bit characters:
> I think that checking in exfat_toupper () can be more simplified.
>
> ex: return a < PLANE_SIZE && sbi->vol_utbl[a] ? sbi->vol_utbl[a] : a;
I was thinking about it, but it needs more refactoring. Currently
exfat_toupper() is used on other places for UTF-16 (u16 array) and
therefore it cannot be extended to take more then 16 bit value.
But I agree that this is another step which can be improved.
next prev parent reply other threads:[~2020-04-08 9:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 2:18 [PATCH 1/4] exfat: Simplify exfat_utf8_d_hash() for code points above U+FFFF Kohada.Tetsuhiro
2020-04-03 20:40 ` Pali Rohár
2020-04-06 9:37 ` Kohada.Tetsuhiro
2020-04-07 10:06 ` Pali Rohár
2020-04-08 3:59 ` Kohada.Tetsuhiro
2020-04-08 9:04 ` Pali Rohár [this message]
2020-04-13 8:13 ` Kohada.Tetsuhiro
2020-04-13 10:10 ` Pali Rohár
2020-04-14 9:29 ` Kohada.Tetsuhiro
2020-04-14 9:47 ` Pali Rohár
2020-04-15 7:46 ` Kohada.Tetsuhiro
-- strict thread matches above, loose matches on Subject: below --
2020-03-17 22:25 [PATCH 0/4] Fixes for exfat driver Pali Rohár
2020-03-17 22:25 ` [PATCH 1/4] exfat: Simplify exfat_utf8_d_hash() for code points above U+FFFF Pali Rohár
2020-03-18 0:09 ` Al Viro
2020-03-18 9:32 ` Pali Rohár
2020-03-28 23:40 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200408090435.i3ufmbfinx5dyd7w@pali \
--to=pali@kernel.org \
--cc=Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sj1557.seo@samsung.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox