From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@infradead.org>,
linux-block <linux-block@vger.kernel.org>,
Damien Le Moal <Damien.LeMoal@wdc.com>,
Keith Busch <kbusch@kernel.org>,
"linux-scsi @ vger . kernel . org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-fsdevel @ vger . kernel . org"
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH v5 07/10] scsi: sd_zbc: emulate ZONE_APPEND commands
Date: Thu, 9 Apr 2020 23:38:55 -0700 [thread overview]
Message-ID: <20200410063855.GC4791@infradead.org> (raw)
In-Reply-To: <20200410061822.GB4791@infradead.org>
On Thu, Apr 09, 2020 at 11:18:22PM -0700, Christoph Hellwig wrote:
> On Fri, Apr 10, 2020 at 01:53:49AM +0900, Johannes Thumshirn wrote:
> > + if (req_op(rq) == REQ_OP_ZONE_APPEND) {
> > + ret = sd_zbc_prepare_zone_append(cmd, &lba, nr_blocks);
> > + if (ret) {
> > + scsi_free_sgtables(cmd);
> > + return ret;
> > + }
> > + }
>
> So actually.
>
> I've been trying to understand the lifetime of the sgtables. Shouldn't
> we free them in the midayer ->init_command returned BLK_STS_*RESOURCE
> instead? It seems like this just catches one particular error instead
> of the whole category? The end of scsi_queue_rq seem like a particular
> good place, as that also releases the resources for the "hard" errors.
Looking more the situation seems even worse. If scsi_mq_prep_fn
isn't successfull we never seem to free the sgtables, even for fatal
errors. So I think we need a real bug fix here in front of the series.
next prev parent reply other threads:[~2020-04-10 6:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 16:53 [PATCH v5 00/10] Introduce Zone Append for writing to zoned block devices Johannes Thumshirn
2020-04-09 16:53 ` [PATCH v5 01/10] block: provide fallbacks for blk_queue_zone_is_seq and blk_queue_zone_no Johannes Thumshirn
2020-04-09 16:53 ` [PATCH v5 02/10] block: Introduce REQ_OP_ZONE_APPEND Johannes Thumshirn
2020-04-10 7:10 ` Christoph Hellwig
2020-04-14 9:43 ` Johannes Thumshirn
2020-04-14 11:28 ` hch
2020-04-09 16:53 ` [PATCH v5 03/10] block: introduce blk_req_zone_write_trylock Johannes Thumshirn
2020-04-09 16:53 ` [PATCH v5 04/10] block: Modify revalidate zones Johannes Thumshirn
2020-04-10 0:27 ` Damien Le Moal
2020-04-10 6:40 ` Christoph Hellwig
2020-04-10 6:55 ` Damien Le Moal
2020-04-09 16:53 ` [PATCH v5 05/10] scsi: sd_zbc: factor out sanity checks for zoned commands Johannes Thumshirn
2020-04-09 16:53 ` [PATCH v5 06/10] scsi: export scsi_mq_free_sgtables Johannes Thumshirn
2020-04-10 5:58 ` Christoph Hellwig
2020-04-10 7:46 ` Johannes Thumshirn
2020-04-10 14:22 ` Bart Van Assche
2020-04-09 16:53 ` [PATCH v5 07/10] scsi: sd_zbc: emulate ZONE_APPEND commands Johannes Thumshirn
2020-04-10 0:30 ` Damien Le Moal
2020-04-10 6:18 ` Christoph Hellwig
2020-04-10 6:38 ` Christoph Hellwig [this message]
2020-04-10 8:01 ` Johannes Thumshirn
2020-04-14 11:09 ` Johannes Thumshirn
2020-04-14 11:30 ` hch
2020-04-10 7:54 ` Johannes Thumshirn
2020-04-10 7:23 ` Christoph Hellwig
2020-04-14 10:18 ` Johannes Thumshirn
2020-04-09 16:53 ` [PATCH v5 08/10] null_blk: Support REQ_OP_ZONE_APPEND Johannes Thumshirn
2020-04-09 16:53 ` [PATCH v5 09/10] block: export bio_release_pages and bio_iov_iter_get_pages Johannes Thumshirn
2020-04-09 16:53 ` [PATCH v5 10/10] zonefs: use REQ_OP_ZONE_APPEND for sync DIO Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200410063855.GC4791@infradead.org \
--to=hch@infradead.org \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).