From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Felix Kuehling <Felix.Kuehling@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.a.wang@intel.com>, Felipe Balbi <balbi@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Jens Axboe <axboe@kernel.dk>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: improve use_mm / unuse_mm v2
Date: Fri, 17 Apr 2020 08:31:02 +0200 [thread overview]
Message-ID: <20200417063102.GA18556@lst.de> (raw)
In-Reply-To: <20200417031744.GI5820@bombadil.infradead.org>
On Thu, Apr 16, 2020 at 08:17:44PM -0700, Matthew Wilcox wrote:
> On Thu, Apr 16, 2020 at 07:31:55AM +0200, Christoph Hellwig wrote:
> > this series improves the use_mm / unuse_mm interface by better
> > documenting the assumptions, and my taking the set_fs manipulations
> > spread over the callers into the core API.
>
> I appreciate all the work you're doing here.
>
> Do you have plans to introduce a better-named API than set_fs() / get_fs()?
Eventually. For now I just plan to kill as many as possible.
> Also, having set_fs() return the previous value of 'fs' would simplify
> a lot of the callers.
One thing that should go relatively soon is the need to store the
previous value because we'll have so few callers left that we know we can't
recurse. We should be able to get there around 5.9 / 5.10.
next prev parent reply other threads:[~2020-04-17 6:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 5:31 improve use_mm / unuse_mm v2 Christoph Hellwig
2020-04-16 5:31 ` [PATCH 1/3] kernel: move use_mm/unuse_mm to kthread.c Christoph Hellwig
2020-04-16 5:31 ` [PATCH 2/3] kernel: better document the use_mm/unuse_mm API contract Christoph Hellwig
2020-04-16 6:43 ` Greg KH
2020-04-16 5:31 ` [PATCH 3/3] kernel: set USER_DS in kthread_use_mm Christoph Hellwig
2020-04-16 6:43 ` Greg KH
2020-04-17 3:17 ` improve use_mm / unuse_mm v2 Matthew Wilcox
2020-04-17 6:31 ` Christoph Hellwig [this message]
2020-04-17 14:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417063102.GA18556@lst.de \
--to=hch@lst.de \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=io-uring@vger.kernel.org \
--cc=jasowang@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-usb@vger.kernel.org \
--cc=mst@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=virtualization@lists.linux-foundation.org \
--cc=willy@infradead.org \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).