From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB134C5518C for ; Wed, 22 Apr 2020 09:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98BA92073A for ; Wed, 22 Apr 2020 09:22:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="FSRMb7oj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726138AbgDVJWz (ORCPT ); Wed, 22 Apr 2020 05:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725924AbgDVJWz (ORCPT ); Wed, 22 Apr 2020 05:22:55 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E6A91C03C1A8; Wed, 22 Apr 2020 02:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LJwNwAXsE+S8zNNlabn/hmZ+oktxf4w2TKCPbz3Xd7Y=; b=FSRMb7ojsDy+kjVHZOZLeU26Hf 9MCf1WYrctgxy1tuPfJMalhsl6zhO/V1ks4bbCVNwwHNLlr2jh6msWOiiWacT1kQsPEYAu/6kGWMb mMxQ8Zu4i1PrJBW9vFNyMWTpN5Lre4ufCpTj3uRHqN0wC2JGN3FonwPzsLmpEd9Tor932GVd0f33N rktqnNf+kW3RdvUgMu8GryUSirp+X5+Kwz3b2uQLGpT8DPabJ2LUrNxxSYFLzws1vD5KwGPX6T2RG VZJzk7YamFtFdSj9Y/sWS0kGIoyQLjwpuZmX+BuTl3PCVg67Sxts9J/5yjryJJPwe2kEvUDKf+T0o PdTaVhrQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jRBak-0006ab-6i; Wed, 22 Apr 2020 09:22:50 +0000 Date: Wed, 22 Apr 2020 02:22:50 -0700 From: Christoph Hellwig To: Satya Tangirala Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-ext4@vger.kernel.org, Barani Muthukumaran , Kuohong Wang , Kim Boojin , Eric Biggers Subject: Re: [PATCH v10 02/12] block: Keyslot Manager for Inline Encryption Message-ID: <20200422092250.GA12290@infradead.org> References: <20200408035654.247908-1-satyat@google.com> <20200408035654.247908-3-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200408035654.247908-3-satyat@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > +bool blk_ksm_crypto_cfg_supported(struct blk_keyslot_manager *ksm, > + const struct blk_crypto_config *cfg) > +{ > + if (!ksm) > + return false; > + return (ksm->crypto_modes_supported[cfg->crypto_mode] & > + cfg->data_unit_size) && > + (ksm->max_dun_bytes_supported >= cfg->dun_bytes); Nit: why not expand this a bit to be more readable: if (!(ksm->crypto_modes_supported[cfg->crypto_mode] & cfg->data_unit_size)) return false; if (ksm->max_dun_bytes_supported < cfg->dun_bytes) return false; return true; > +int blk_ksm_evict_key(struct blk_keyslot_manager *ksm, > + const struct blk_crypto_key *key) > +{ > + struct blk_ksm_keyslot *slot; > + int err = 0; > + > + blk_ksm_hw_enter(ksm); > + slot = blk_ksm_find_keyslot(ksm, key); > + if (!slot) > + goto out_unlock; > + > + if (atomic_read(&slot->slot_refs) != 0) { > + err = -EBUSY; > + goto out_unlock; > + } This check looks racy.