From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
Naohiro Aota <Naohiro.Aota@wdc.com>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Johannes Thumshirn <jth@kernel.org>
Subject: Re: [PATCH v1] zonefs: Replace uuid_copy() with import_uuid()
Date: Thu, 23 Apr 2020 18:51:05 +0300 [thread overview]
Message-ID: <20200423155105.GX185537@smile.fi.intel.com> (raw)
In-Reply-To: <BYAPR04MB49654BB8430FA45980CB64D186D30@BYAPR04MB4965.namprd04.prod.outlook.com>
On Thu, Apr 23, 2020 at 03:43:32PM +0000, Chaitanya Kulkarni wrote:
> On 04/23/2020 08:32 AM, Andy Shevchenko wrote:
> > There is a specific API to treat raw data as UUID, i.e. import_uuid().
> > Use it instead of uuid_copy() with explicit casting.
> >
> > Signed-off-by: Andy Shevchenko<andriy.shevchenko@linux.intel.com>
>
> At the end it does the same thing,
For now yes, who knows how uuid_t will look like in the future...
> I think we can avoid cast though.
This and possibility to change uuid_t if needed.
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Thanks!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-04-23 15:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 15:32 [PATCH v1] zonefs: Replace uuid_copy() with import_uuid() Andy Shevchenko
2020-04-23 15:43 ` Chaitanya Kulkarni
2020-04-23 15:51 ` Andy Shevchenko [this message]
2020-04-23 16:41 ` Johannes Thumshirn
2020-04-26 23:59 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423155105.GX185537@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=Naohiro.Aota@wdc.com \
--cc=jth@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox