From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D6FEC83004 for ; Tue, 28 Apr 2020 06:57:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9FAC206B9 for ; Tue, 28 Apr 2020 06:57:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726386AbgD1G5G (ORCPT ); Tue, 28 Apr 2020 02:57:06 -0400 Received: from verein.lst.de ([213.95.11.211]:54392 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726315AbgD1G5G (ORCPT ); Tue, 28 Apr 2020 02:57:06 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 8A16E68C7B; Tue, 28 Apr 2020 08:57:03 +0200 (CEST) Date: Tue, 28 Apr 2020 08:57:03 +0200 From: Christoph Hellwig To: Jeremy Kerr Cc: Al Viro , Christoph Hellwig , Andrew Morton , Linus Torvalds , Arnd Bergmann , "Eric W . Biederman" , linuxppc-dev@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] powerpc/spufs: simplify spufs core dumping Message-ID: <20200428065703.GB18754@lst.de> References: <20200427200626.1622060-1-hch@lst.de> <20200427200626.1622060-2-hch@lst.de> <20200427204953.GY23230@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, Apr 28, 2020 at 10:51:56AM +0800, Jeremy Kerr wrote: > Hi Al & Christoph, > > > Again, this really needs fixing. Preferably - as a separate commit > > preceding this series, so that it could be > > backported. simple_read_from_buffer() is a blocking operation. > > I'll put together a patch that fixes this. > > Christoph: I'll do it in a way that matches your changes to the _read > functions, so hopefully those hunks would just drop from your change, > leaving only the _dump additions. Would that work? Sure.