From: Miklos Szeredi <mszeredi@redhat.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, David Howells <dhowells@redhat.com>
Subject: [PATCH 07/12] statx: don't clear STATX_ATIME on SB_RDONLY
Date: Tue, 5 May 2020 11:59:10 +0200 [thread overview]
Message-ID: <20200505095915.11275-8-mszeredi@redhat.com> (raw)
In-Reply-To: <20200505095915.11275-1-mszeredi@redhat.com>
IS_NOATIME(inode) is defined as __IS_FLG(inode, SB_RDONLY|SB_NOATIME), so
generic_fillattr() will clear STATX_ATIME from the result_mask if the super
block is marked read only.
This was probably not the intention, so fix to only clear STATX_ATIME if
the fs doesn't support atime at all.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Acked-by: David Howells <dhowells@redhat.com>
---
fs/stat.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/stat.c b/fs/stat.c
index a6709e7ba71d..f7f07d1b73cb 100644
--- a/fs/stat.c
+++ b/fs/stat.c
@@ -73,7 +73,8 @@ int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
query_flags &= KSTAT_QUERY_FLAGS;
/* allow the fs to override these if it really wants to */
- if (IS_NOATIME(inode))
+ /* SB_NOATIME means filesystem supplies dummy atime value */
+ if (inode->i_sb->s_flags & SB_NOATIME)
stat->result_mask &= ~STATX_ATIME;
if (IS_AUTOMOUNT(inode))
stat->attributes |= STATX_ATTR_AUTOMOUNT;
--
2.21.1
next prev parent reply other threads:[~2020-05-05 9:59 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 9:59 [PATCH 00/12] vfs patch queue Miklos Szeredi
2020-05-05 9:59 ` [PATCH 01/12] vfs: allow unprivileged whiteout creation Miklos Szeredi
2020-05-13 19:12 ` Al Viro
2020-05-05 9:59 ` [PATCH 02/12] aio: fix async fsync creds Miklos Szeredi
2020-05-13 10:01 ` Christoph Hellwig
2020-05-05 9:59 ` [PATCH 03/12] proc/mounts: add cursor Miklos Szeredi
2020-05-13 19:33 ` Al Viro
2020-05-05 9:59 ` [PATCH 04/12] utimensat: AT_EMPTY_PATH support Miklos Szeredi
2020-05-13 10:02 ` Christoph Hellwig
2020-05-05 9:59 ` [PATCH 05/12] f*xattr: allow O_PATH descriptors Miklos Szeredi
2020-05-13 10:04 ` Christoph Hellwig
2020-05-14 8:02 ` Miklos Szeredi
2020-05-14 13:01 ` Miklos Szeredi
2020-05-05 9:59 ` [PATCH 06/12] uapi: deprecate STATX_ALL Miklos Szeredi
2020-05-13 10:04 ` Christoph Hellwig
2020-05-05 9:59 ` Miklos Szeredi [this message]
2020-05-13 10:04 ` [PATCH 07/12] statx: don't clear STATX_ATIME on SB_RDONLY Christoph Hellwig
2020-05-05 9:59 ` [PATCH 08/12] statx: add mount ID Miklos Szeredi
2020-05-13 10:05 ` Christoph Hellwig
2020-05-05 9:59 ` [PATCH 09/12] statx: add mount_root Miklos Szeredi
2020-05-05 14:24 ` J . Bruce Fields
2020-05-13 10:05 ` Christoph Hellwig
2020-05-05 9:59 ` [PATCH 10/12] vfs: don't parse forbidden flags Miklos Szeredi
2020-05-13 10:06 ` Christoph Hellwig
2020-05-05 9:59 ` [PATCH 11/12] vfs: don't parse "posixacl" option Miklos Szeredi
2020-05-13 10:07 ` Christoph Hellwig
2020-05-05 9:59 ` [PATCH 12/12] vfs: don't parse "silent" option Miklos Szeredi
2020-05-13 10:07 ` Christoph Hellwig
2020-05-13 7:45 ` [13/12 PATCH] vfs: add faccessat2 syscall Miklos Szeredi
2020-05-13 10:09 ` Christoph Hellwig
2020-05-13 7:47 ` [PATCH 00/12] vfs patch queue Miklos Szeredi
2020-05-13 19:48 ` Al Viro
2020-05-14 11:46 ` Miklos Szeredi
2020-05-14 14:55 ` Miklos Szeredi
2020-05-14 15:10 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505095915.11275-8-mszeredi@redhat.com \
--to=mszeredi@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).