From: Baoquan He <bhe@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Rafael Aquini <aquini@redhat.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org,
dyoung@redhat.com, corbet@lwn.net, mcgrof@kernel.org,
keescook@chromium.org, akpm@linux-foundation.org, cai@lca.pw,
tytso@mit.edu, bunk@kernel.org, torvalds@linux-foundation.org,
gregkh@linuxfoundation.org, labbott@redhat.com, jeffm@suse.com,
jikos@kernel.org, jeyu@suse.de, tiwai@suse.de, AnDavis@suse.com,
rpalethorpe@suse.de
Subject: Re: [PATCH v3] kernel: add panic_on_taint
Date: Sun, 10 May 2020 13:16:46 +0800 [thread overview]
Message-ID: <20200510051646.GF5029@MiWiFi-R3L-srv> (raw)
In-Reply-To: <acab7971-7522-3511-c976-e0237ceda4d0@infradead.org>
On 05/09/20 at 09:10pm, Randy Dunlap wrote:
> On 5/9/20 7:59 PM, Baoquan He wrote:
> > Read admin-guide/tainted-kernels.rst, but still do not get what 'G' means.
>
> I interpret 'G' as GPL (strictly it means that no proprietary module has
> been loaded). But I don't see why TAINT_PROPRIETARY_MODULE is the only
> taint flag that has a non-blank c_false character. It could just be blank
> also AFAICT. Then the 'G' would not be there to confuse us. :)
Yeah, seems c_false character is not so necessary. If no 'P' set, then
it means no proprietary modules loaded naturally. We may need clean up
the c_false in struct taint_flag, since c_true is enough to indicate
what want to check.
next prev parent reply other threads:[~2020-05-10 5:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 13:57 [PATCH v3] kernel: add panic_on_taint Rafael Aquini
2020-05-09 18:59 ` Kees Cook
2020-05-10 2:59 ` Baoquan He
2020-05-10 4:10 ` Randy Dunlap
2020-05-10 5:16 ` Baoquan He [this message]
2020-05-10 18:22 ` Rafael Aquini
2020-05-11 1:11 ` Baoquan He
2020-05-11 18:24 ` Luis Chamberlain
2020-05-11 20:03 ` Rafael Aquini
2020-05-11 21:05 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200510051646.GF5029@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=AnDavis@suse.com \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=bunk@kernel.org \
--cc=cai@lca.pw \
--cc=corbet@lwn.net \
--cc=dyoung@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeffm@suse.com \
--cc=jeyu@suse.de \
--cc=jikos@kernel.org \
--cc=keescook@chromium.org \
--cc=kexec@lists.infradead.org \
--cc=labbott@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rpalethorpe@suse.de \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).