[PATCH V2 0/6 linux-next] fs/notify: cleanup

[PATCH V2 0/6 linux-next] fs/notify: cleanup

[Fabian Frederick]

This small patchset does some cleanup in fs/notify branch
especially in fanotify.

V2:
Apply Amir Goldstein suggestions:
-Remove patch 2, 7 and 9
-Patch "fanotify: don't write with zero size" ->
"fanotify: don't write with size under sizeof(response)"

Fabian Frederick (6):
  fanotify: prefix should_merge()
  notify: explicit shutdown initialization
  notify: add mutex destroy
  fanotify: remove reference to fill_event_metadata()
  fsnotify/fdinfo: remove proc_fs.h inclusion
  fanotify: don't write with size under sizeof(response)

 fs/notify/fanotify/fanotify.c      | 4 ++--
 fs/notify/fanotify/fanotify_user.c | 8 +++++---
 fs/notify/fdinfo.c                 | 1 -
 fs/notify/group.c                  | 2 ++
 4 files changed, 9 insertions(+), 6 deletions(-)

-- 
2.26.2

Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup

[Amir Goldstein]

On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
>
> This small patchset does some cleanup in fs/notify branch
> especially in fanotify.

Patches look fine to me.
I would just change the subject of patches from notify: to fsnotify:.
The patch "explicit shutdown initialization" is border line unneeded
and its subject is not very descriptive.
Let's wait and see what Jan has to say before you post another round.

Thanks,
Amir.

>
> V2:
> Apply Amir Goldstein suggestions:
> -Remove patch 2, 7 and 9
> -Patch "fanotify: don't write with zero size" ->
> "fanotify: don't write with size under sizeof(response)"
>
> Fabian Frederick (6):
>   fanotify: prefix should_merge()
>   notify: explicit shutdown initialization
>   notify: add mutex destroy
>   fanotify: remove reference to fill_event_metadata()
>   fsnotify/fdinfo: remove proc_fs.h inclusion
>   fanotify: don't write with size under sizeof(response)
>
>  fs/notify/fanotify/fanotify.c      | 4 ++--
>  fs/notify/fanotify/fanotify_user.c | 8 +++++---
>  fs/notify/fdinfo.c                 | 1 -
>  fs/notify/group.c                  | 2 ++
>  4 files changed, 9 insertions(+), 6 deletions(-)
>
> --
> 2.26.2
>

Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup

[Jan Kara]

On Tue 12-05-20 21:32:10, Amir Goldstein wrote:
> On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
> >
> > This small patchset does some cleanup in fs/notify branch
> > especially in fanotify.
> 
> Patches look fine to me.
> I would just change the subject of patches from notify: to fsnotify:.
> The patch "explicit shutdown initialization" is border line unneeded
> and its subject is not very descriptive.
> Let's wait and see what Jan has to say before you post another round.

Yeah, I think patch 2 doesn't make sence but the rest looks good. Can I add
your Reviewed-by Amir when merging them?

								Honza

> > V2:
> > Apply Amir Goldstein suggestions:
> > -Remove patch 2, 7 and 9
> > -Patch "fanotify: don't write with zero size" ->
> > "fanotify: don't write with size under sizeof(response)"
> >
> > Fabian Frederick (6):
> >   fanotify: prefix should_merge()
> >   notify: explicit shutdown initialization
> >   notify: add mutex destroy
> >   fanotify: remove reference to fill_event_metadata()
> >   fsnotify/fdinfo: remove proc_fs.h inclusion
> >   fanotify: don't write with size under sizeof(response)
> >
> >  fs/notify/fanotify/fanotify.c      | 4 ++--
> >  fs/notify/fanotify/fanotify_user.c | 8 +++++---
> >  fs/notify/fdinfo.c                 | 1 -
> >  fs/notify/group.c                  | 2 ++
> >  4 files changed, 9 insertions(+), 6 deletions(-)
> >
> > --
> > 2.26.2
> >
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup

[Amir Goldstein]

On Wed, May 13, 2020 at 2:08 PM Jan Kara <jack@suse.cz> wrote:
>
> On Tue 12-05-20 21:32:10, Amir Goldstein wrote:
> > On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
> > >
> > > This small patchset does some cleanup in fs/notify branch
> > > especially in fanotify.
> >
> > Patches look fine to me.
> > I would just change the subject of patches from notify: to fsnotify:.
> > The patch "explicit shutdown initialization" is border line unneeded
> > and its subject is not very descriptive.
> > Let's wait and see what Jan has to say before you post another round.
>
> Yeah, I think patch 2 doesn't make sence but the rest looks good. Can I add
> your Reviewed-by Amir when merging them?

Yes.

Thanks,
Amir.

Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup

[Jan Kara]

On Wed 13-05-20 14:10:54, Amir Goldstein wrote:
> On Wed, May 13, 2020 at 2:08 PM Jan Kara <jack@suse.cz> wrote:
> >
> > On Tue 12-05-20 21:32:10, Amir Goldstein wrote:
> > > On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
> > > >
> > > > This small patchset does some cleanup in fs/notify branch
> > > > especially in fanotify.
> > >
> > > Patches look fine to me.
> > > I would just change the subject of patches from notify: to fsnotify:.
> > > The patch "explicit shutdown initialization" is border line unneeded
> > > and its subject is not very descriptive.
> > > Let's wait and see what Jan has to say before you post another round.
> >
> > Yeah, I think patch 2 doesn't make sence but the rest looks good. Can I add
> > your Reviewed-by Amir when merging them?
> 
> Yes.

Thanks. Fabian, I've merged the cleanups to my tree.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR