From: Jan Kara <jack@suse.cz>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Jan Kara <jack@suse.cz>, Fabian Frederick <fabf@skynet.be>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH V2 0/6 linux-next] fs/notify: cleanup
Date: Wed, 13 May 2020 17:35:30 +0200 [thread overview]
Message-ID: <20200513153530.GA9569@quack2.suse.cz> (raw)
In-Reply-To: <CAOQ4uxiUXgW7HyMaHoqFH6kZnrTPNd=Rgfj6duO8aKc87mhCCw@mail.gmail.com>
On Wed 13-05-20 14:10:54, Amir Goldstein wrote:
> On Wed, May 13, 2020 at 2:08 PM Jan Kara <jack@suse.cz> wrote:
> >
> > On Tue 12-05-20 21:32:10, Amir Goldstein wrote:
> > > On Tue, May 12, 2020 at 9:16 PM Fabian Frederick <fabf@skynet.be> wrote:
> > > >
> > > > This small patchset does some cleanup in fs/notify branch
> > > > especially in fanotify.
> > >
> > > Patches look fine to me.
> > > I would just change the subject of patches from notify: to fsnotify:.
> > > The patch "explicit shutdown initialization" is border line unneeded
> > > and its subject is not very descriptive.
> > > Let's wait and see what Jan has to say before you post another round.
> >
> > Yeah, I think patch 2 doesn't make sence but the rest looks good. Can I add
> > your Reviewed-by Amir when merging them?
>
> Yes.
Thanks. Fabian, I've merged the cleanups to my tree.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2020-05-13 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 18:16 [PATCH V2 0/6 linux-next] fs/notify: cleanup Fabian Frederick
2020-05-12 18:32 ` Amir Goldstein
2020-05-13 11:08 ` Jan Kara
2020-05-13 11:10 ` Amir Goldstein
2020-05-13 15:35 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513153530.GA9569@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=fabf@skynet.be \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).