From: Luis Chamberlain <mcgrof@kernel.org>
To: Xiaoming Ni <nixiaoming@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
keescook@chromium.org, yzaikin@google.com, adobriyan@gmail.com,
mingo@kernel.org, gpiccoli@canonical.com, rdna@fb.com,
patrick.bellasi@arm.com, sfr@canb.auug.org.au, mhocko@suse.com,
penguin-kernel@i-love.sakura.ne.jp, vbabka@suse.cz,
tglx@linutronix.de, peterz@infradead.org,
Jisheng.Zhang@synaptics.com, khlebnikov@yandex-team.ru,
bigeasy@linutronix.de, pmladek@suse.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
wangle6@huawei.com, alex.huangjianhui@huawei.com
Subject: Re: [PATCH v4 0/4] cleaning up the sysctls table (hung_task watchdog)
Date: Wed, 20 May 2020 13:08:03 +0000 [thread overview]
Message-ID: <20200520130802.GW11244@42.do-not-panic.com> (raw)
In-Reply-To: <5574b304-e890-76a9-8190-f705eba8082d@huawei.com>
On Wed, May 20, 2020 at 12:02:26PM +0800, Xiaoming Ni wrote:
> On 2020/5/20 11:31, Andrew Morton wrote:
> > On Tue, 19 May 2020 11:31:07 +0800 Xiaoming Ni <nixiaoming@huawei.com> wrote:
> >
> > > Kernel/sysctl.c
> >
> > eek!
> >
> > >
> > > fs/proc/proc_sysctl.c | 2 +-
> > > include/linux/sched/sysctl.h | 14 +--
> > > include/linux/sysctl.h | 13 ++-
> > > kernel/hung_task.c | 77 +++++++++++++++-
> > > kernel/sysctl.c | 214 +++++++------------------------------------
> > > kernel/watchdog.c | 101 ++++++++++++++++++++
> > > 6 files changed, 224 insertions(+), 197 deletions(-)
> >
> > Here's what we presently have happening in linux-next's kernel/sysctl.c:
> >
> > sysctl.c | 3109 ++++++++++++++++++++++++++++++---------------------------------
> > 1 file changed, 1521 insertions(+), 1588 deletions(-)
> >
> >
> > So this is not a good time for your patch!
> >
> > Can I suggest that you set the idea aside and take a look after 5.8-rc1
> > is released?
> >
>
> ok, I will make v5 patch based on 5.8-rc1 after 5.8-rc1 is released,
> And add more sysctl table cleanup.
Xiaoming, I'll coordinate with you on this offline as I have the fs
kernel/sysctl.c stuff out of the way as well.
Luis
prev parent reply other threads:[~2020-05-20 13:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 3:31 [PATCH v4 0/4] cleaning up the sysctls table (hung_task watchdog) Xiaoming Ni
2020-05-19 3:31 ` [PATCH v4 1/4] sysctl: Add register_sysctl_init() interface Xiaoming Ni
2020-05-29 7:09 ` Luis Chamberlain
2020-05-29 7:27 ` Xiaoming Ni
2020-05-29 7:36 ` Luis Chamberlain
2020-05-29 8:33 ` Xiaoming Ni
2020-05-29 11:31 ` Luis Chamberlain
2020-05-19 3:31 ` [PATCH v4 2/4] sysctl: Move some boundary constants form sysctl.c to sysctl_vals Xiaoming Ni
2020-05-19 4:44 ` Tetsuo Handa
2020-05-20 1:14 ` Xiaoming Ni
2020-05-20 1:39 ` Luis Chamberlain
2020-05-19 3:31 ` [PATCH v4 3/4] hung_task: Move hung_task sysctl interface to hung_task.c Xiaoming Ni
2020-05-19 3:31 ` [PATCH v4 4/4] watchdog: move watchdog sysctl interface to watchdog.c Xiaoming Ni
2020-05-20 3:31 ` [PATCH v4 0/4] cleaning up the sysctls table (hung_task watchdog) Andrew Morton
2020-05-20 4:02 ` Xiaoming Ni
2020-05-20 13:08 ` Luis Chamberlain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520130802.GW11244@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=Jisheng.Zhang@synaptics.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alex.huangjianhui@huawei.com \
--cc=bigeasy@linutronix.de \
--cc=gpiccoli@canonical.com \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=nixiaoming@huawei.com \
--cc=patrick.bellasi@arm.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rdna@fb.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=wangle6@huawei.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).