From: Krzysztof Wilczynski <kw@linux.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
linux-fsdevel@vger.kernel.org,
"Krzysztof Wilczyński" <kw@linux.com>
Subject: [PATCH] fs: Remove duplicated flag from VALID_OPEN_FLAGS
Date: Fri, 22 May 2020 13:37:23 +0000 [thread overview]
Message-ID: <20200522133723.1091937-1-kw@linux.com> (raw)
From: Krzysztof Wilczyński <kw@linux.com>
Also, remove extra tab after the FASYNC flag, and keep line under 80
characters. This also resolves the following Coccinelle warning:
include/linux/fcntl.h:11:13-21: duplicated argument to & or |
And following checkpatch.pl warning:
WARNING: line over 80 characters
#10: FILE: include/linux/fcntl.h:10:
+ (O_RDONLY | O_WRONLY | O_RDWR | O_CREAT | O_EXCL | O_NOCTTY
| O_TRUNC | \
Signed-off-by: Krzysztof Wilczyński <kw@linux.com>
---
include/linux/fcntl.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/fcntl.h b/include/linux/fcntl.h
index 7bcdcf4f6ab2..be3e445eba18 100644
--- a/include/linux/fcntl.h
+++ b/include/linux/fcntl.h
@@ -7,9 +7,9 @@
/* List of all valid flags for the open/openat flags argument: */
#define VALID_OPEN_FLAGS \
- (O_RDONLY | O_WRONLY | O_RDWR | O_CREAT | O_EXCL | O_NOCTTY | O_TRUNC | \
- O_APPEND | O_NDELAY | O_NONBLOCK | O_NDELAY | __O_SYNC | O_DSYNC | \
- FASYNC | O_DIRECT | O_LARGEFILE | O_DIRECTORY | O_NOFOLLOW | \
+ (O_RDONLY | O_WRONLY | O_RDWR | O_CREAT | O_EXCL | O_NOCTTY | \
+ O_TRUNC | O_APPEND | O_NDELAY | O_NONBLOCK | __O_SYNC | O_DSYNC | \
+ FASYNC | O_DIRECT | O_LARGEFILE | O_DIRECTORY | O_NOFOLLOW | \
O_NOATIME | O_CLOEXEC | O_PATH | __O_TMPFILE)
/* List of all valid flags for the how->upgrade_mask argument: */
--
2.26.2
next reply other threads:[~2020-05-22 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 13:37 Krzysztof Wilczynski [this message]
2020-05-22 15:47 ` [PATCH] fs: Remove duplicated flag from VALID_OPEN_FLAGS Al Viro
2020-05-22 17:01 ` Matthew Wilcox
2020-05-22 17:18 ` Al Viro
2020-05-22 17:32 ` Krzysztof Wilczynski
2020-05-22 17:22 ` Krzysztof Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522133723.1091937-1-kw@linux.com \
--to=kw@linux.com \
--cc=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).