From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CECCC433DF for ; Fri, 22 May 2020 15:47:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6F8A206F6 for ; Fri, 22 May 2020 15:47:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730137AbgEVPr0 (ORCPT ); Fri, 22 May 2020 11:47:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730058AbgEVPr0 (ORCPT ); Fri, 22 May 2020 11:47:26 -0400 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09540C061A0E for ; Fri, 22 May 2020 08:47:26 -0700 (PDT) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.93 #3 (Red Hat Linux)) id 1jc9tH-00DZe0-SX; Fri, 22 May 2020 15:47:20 +0000 Date: Fri, 22 May 2020 16:47:19 +0100 From: Al Viro To: Krzysztof Wilczynski Cc: Jeff Layton , "J. Bruce Fields" , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs: Remove duplicated flag from VALID_OPEN_FLAGS Message-ID: <20200522154719.GS23230@ZenIV.linux.org.uk> References: <20200522133723.1091937-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200522133723.1091937-1-kw@linux.com> Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, May 22, 2020 at 01:37:23PM +0000, Krzysztof Wilczynski wrote: > From: Krzysztof WilczyƄski > > Also, remove extra tab after the FASYNC flag, and keep line under 80 > characters. This also resolves the following Coccinelle warning: > > include/linux/fcntl.h:11:13-21: duplicated argument to & or | Now ask yourself what might be the reason for that "duplicated argument". Try to figure out what the values of those constants might depend upon. For extra points, try to guess what has caused the divergences. Please, post the result of your investigation in followup to this.